Page MenuHomeFreeBSD

bsdinstall: jail: Fix DISTMENU items
ClosedPublic

Authored by jlduran on Oct 17 2025, 6:47 PM.
Tags
None
Referenced Files
F139145555: D53177.diff
Mon, Dec 8, 12:50 PM
Unknown Object (File)
Thu, Dec 4, 10:03 PM
Unknown Object (File)
Sun, Nov 30, 1:23 PM
Unknown Object (File)
Thu, Nov 20, 2:33 PM
Unknown Object (File)
Nov 6 2025, 11:48 PM
Unknown Object (File)
Nov 2 2025, 11:37 PM
Unknown Object (File)
Oct 30 2025, 4:07 PM
Unknown Object (File)
Oct 29 2025, 5:36 PM
Subscribers

Details

Summary

The menu was incorrectly using the fourth column (distname) instead of
the first (dist) of the MANIFEST.

The actual file name is on the first column of the MANIFEST file.
Remove the .txz part of the name to build the menu options.

Test Plan
  1. Create a jail using bsdinstall:
# mkdir -p /jail/dists
# bsdinstall jail /jail/dists
  1. Choose "Distribution Sets".
  2. Choose "lib32-dbg" (without this patch, it will show up as "lib32_dbg" and fail).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran edited the test plan for this revision. (Show Details)
jlduran added reviewers: emaste, jrtc27.
jlduran edited the summary of this revision. (Show Details)

Thinking about it, I probably won't probably come back to work on bsdinstall.
Apply a minimal fix.

  • We are not looking for POSIX comliance. A few other scripts are also using double equals for comparison, let's not change that for now.
  • Update the description to better reflect that without this patch any selected set that contains a hyphen will fail to download.
jlduran edited the test plan for this revision. (Show Details)
jamie added a subscriber: jamie.

It only touches peripherally on jails, but sure, looks good. One could ask why we decided to have a separate and subtlely different "dist" and "distname" but I suppose that's water long since under the bridge.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 22 2025, 6:23 PM
This revision was automatically updated to reflect the committed changes.

It only touches peripherally on jails, but sure, looks good. One could ask why we decided to have a separate and subtlely different "dist" and "distname" but I suppose that's water long since under the bridge.

Thank you!