Page MenuHomeFreeBSD

libnv: Fix a length check in nvpair_unpack_string_array()
ClosedPublic

Authored by markj on Oct 13 2025, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 8, 1:13 PM
Unknown Object (File)
Sun, Feb 8, 3:17 AM
Unknown Object (File)
Sun, Feb 1, 11:29 PM
Unknown Object (File)
Sun, Feb 1, 11:05 PM
Unknown Object (File)
Sat, Jan 31, 1:46 AM
Unknown Object (File)
Thu, Jan 22, 11:24 AM
Unknown Object (File)
Dec 19 2025, 9:43 AM
Unknown Object (File)
Dec 12 2025, 11:51 AM
Subscribers

Details

Summary

A string array is represented by a set of nul-terminated strings
concatenated together. For each string, we check to see if there's a
nul terminator at the end, taking care to avoid going past the end of
the buffer. However, the code fails to handle the possibility that
size == 0 at the end of an iteration, leading to underflow.

Fix the length check.

Reported by: Ilja van Sprundel <ivansprundel@ioactive.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable