Page MenuHomeFreeBSD

libnv: Fix a length check in nvpair_unpack_string_array()
ClosedPublic

Authored by markj on Oct 13 2025, 1:44 PM.
Tags
None
Referenced Files
F152510158: D53069.id.diff
Wed, Apr 15, 10:17 AM
F152451389: D53069.id164092.diff
Wed, Apr 15, 1:29 AM
Unknown Object (File)
Sat, Apr 11, 2:54 PM
Unknown Object (File)
Sat, Apr 11, 5:14 AM
Unknown Object (File)
Tue, Apr 7, 1:48 PM
Unknown Object (File)
Sun, Apr 5, 3:25 AM
Unknown Object (File)
Sun, Mar 29, 12:38 PM
Unknown Object (File)
Tue, Mar 24, 7:28 PM
Subscribers

Details

Summary

A string array is represented by a set of nul-terminated strings
concatenated together. For each string, we check to see if there's a
nul terminator at the end, taking care to avoid going past the end of
the buffer. However, the code fails to handle the possibility that
size == 0 at the end of an iteration, leading to underflow.

Fix the length check.

Reported by: Ilja van Sprundel <ivansprundel@ioactive.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable