Differential D53025

realpath: Report correct path on failure
ClosedPublic
Actions

Authored by des on Oct 10 2025, 2:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 30, 6:12 AM

	Unknown Object (File)
	Tue, Nov 25, 12:08 AM

	Unknown Object (File)
	Sun, Nov 23, 11:25 PM

	Unknown Object (File)
	Sun, Nov 23, 2:31 PM

	Unknown Object (File)
	Sun, Nov 23, 4:04 AM

	Unknown Object (File)
	Fri, Nov 21, 12:29 PM

	Unknown Object (File)
	Wed, Nov 19, 4:05 AM

	Unknown Object (File)
	Tue, Nov 18, 7:11 PM

View All 37 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG38c42ca57ba5: realpath: Report correct path on failure
rG6c9b25246d44: realpath: Report correct path on failure
rGbebae0e23129: realpath: Report correct path on failure
rG1406de21e176: realpath: Report correct path on failure

Summary

If lstat() fails with EACCES or ENOTDIR, the path we need to return in
the caller-provided buffer is that of the parent directory (which is
either unreadable or not a directory; the latter can only happen in the
case of a race) rather than that of the child we attempted to stat.

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Oct 10 2025, 2:05 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 10 2025, 2:05 PM

des requested review of this revision.Oct 10 2025, 2:05 PM

Harbormaster completed remote builds in B67699: Diff 163938.Oct 10 2025, 2:05 PM

des added a parent revision: D53024: realpath: Additional test cases.Oct 10 2025, 2:05 PM

des added a child revision: D53026: realpath: Avoid doing unnecessary work.

fix trailing slash

Harbormaster completed remote builds in B67702: Diff 163941.Oct 10 2025, 2:25 PM

markj accepted this revision as: markj.Oct 10 2025, 7:13 PM

This revision is now accepted and ready to land.Oct 10 2025, 7:13 PM

Closed by commit rG1406de21e176: realpath: Report correct path on failure (authored by des). · Explain WhyOct 13 2025, 11:55 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG1406de21e176: realpath: Report correct path on failure.

des added a commit: rGbebae0e23129: realpath: Report correct path on failure.Oct 20 2025, 4:12 PM

des added a commit: rG6c9b25246d44: realpath: Report correct path on failure.

cperciva added a commit: rG38c42ca57ba5: realpath: Report correct path on failure.Oct 30 2025, 11:59 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdlib/

14 lines

tests/

gen/

realpath2_test.c

11 lines

Diff 164082

lib/libc/stdlib/realpath.c

Loading...

lib/libc/tests/gen/realpath2_test.c

Loading...