Page MenuHomeFreeBSD

inline most of the considered lost condensation.
Needs ReviewPublic

Authored by rrs on Fri, Oct 10, 12:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 11:23 AM
Unknown Object (File)
Sat, Oct 11, 7:26 AM
Unknown Object (File)
Sat, Oct 11, 12:47 AM
Unknown Object (File)
Fri, Oct 10, 11:52 PM
Unknown Object (File)
Fri, Oct 10, 8:07 PM
Unknown Object (File)
Fri, Oct 10, 8:04 PM
Unknown Object (File)
Fri, Oct 10, 8:02 PM
Unknown Object (File)
Fri, Oct 10, 7:54 PM
Subscribers

Details

Reviewers
tuexen
Group Reviewers
transport
Summary

This is a small cleanup to consolidate the considered lost reduction and marking to an
inline function. There are two places where we are using hookery in SACK processing where
we can't use it. All other places we move to the function. This code in theory changes nothing
and just makes things a bit more readable and consistent.

Test Plan

Run with invariants the tcp test suite and make sure we don't hit the KASSERTS where we have
messed up the counts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rrs requested review of this revision.Fri, Oct 10, 12:08 PM
sys/netinet/tcp_stacks/rack.c
6873

Underscored inline is a GNU-ism. Without underscores it is a C99 keyword.

Here are simple rules of use in FreeBSD: when used in .c files, always use C99 keyword. When used in .h file use GNU extension if this is a standard file, that can be included anywhere and potentially compiled in C89/C90 modes. If the .h file is specific to FreeBSD, then C language keyword is preferred.

sys/netinet/tcp_stacks/rack.c
6873

Ahh I did not know that... I was just cloning a previous inline .. will change to the non __inline :)

Adopt Gleb's suggestion on __inline -> inline (other places need that change too) :)