Page MenuHomeFreeBSD

diff3: Move to own package
ClosedPublic

Authored by emaste on Tue, Sep 30, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 11:58 PM
Unknown Object (File)
Thu, Oct 9, 11:58 PM
Unknown Object (File)
Thu, Oct 9, 11:58 PM
Unknown Object (File)
Thu, Oct 9, 11:58 PM
Unknown Object (File)
Thu, Oct 9, 11:58 PM
Unknown Object (File)
Thu, Oct 9, 8:02 PM
Unknown Object (File)
Sat, Oct 4, 4:13 PM
Unknown Object (File)
Wed, Oct 1, 11:18 PM
Subscribers

Details

Summary
diff3 is the last remaining GPL-licensed userland component.  Move it
to its own package, so that it may be excluded if desired.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
ivy requested changes to this revision.Wed, Oct 1, 8:21 AM
ivy added a subscriber: ivy.

i don't usually like a single utility being in its own package, but given the license issue this seems reasonable.

however, you did not add a UCL file for the new package :-)

This revision now requires changes to proceed.Wed, Oct 1, 8:21 AM

i would suggest adding licenses = [ "GPL-2.0-or-later" ]. although most of the license metadata is wrong, we should at least set it correctly for a package that only exists because of licensing issues.

also, please add a license header to the UCL file itself, i've recently updated nearly all of them to have one.

aside from that, looks fine.

This revision is now accepted and ready to land.Wed, Oct 1, 9:36 AM

add license for package and SPDX tag for the metadata itself

This revision now requires review to proceed.Wed, Oct 1, 10:06 AM
This revision is now accepted and ready to land.Wed, Oct 1, 10:08 AM
This revision was automatically updated to reflect the committed changes.