Differential D52713

ng_tty: copy to the correct mbuf
ClosedPublic
Actions

Authored by vexeduxr on Sep 24 2025, 3:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 21, 12:36 PM

	Unknown Object (File)
	Sat, Apr 18, 4:11 AM

	Unknown Object (File)
	Tue, Apr 14, 10:37 PM

	Unknown Object (File)
	Mon, Apr 6, 6:40 PM

	Unknown Object (File)
	Sun, Apr 5, 9:21 PM

	Unknown Object (File)
	Mar 31 2026, 12:52 AM

	Unknown Object (File)
	Mar 30 2026, 3:26 PM

	Unknown Object (File)
	Mar 30 2026, 7:21 AM

View All 69 Files

Subscribers

Details

Reviewers

kevans
glebius

Commits

rG51cac1f186f5: ng_tty: copy to the correct mbuf
rGb6ad8caa24c2: ng_tty: copy to the correct mbuf
rG2ae71a5e9ffb: ng_tty: copy to the correct mbuf
rGe05521121f05: ng_tty: copy to the correct mbuf

Summary

memcpy should copy to the current mbuf, otherwise we're copying to the
first mbuf in the chain over and over.

Reported by: kevans
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vexeduxr created this revision.Sep 24 2025, 3:55 PM

Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptSep 24 2025, 3:55 PM

vexeduxr requested review of this revision.Sep 24 2025, 3:55 PM

Harbormaster completed remote builds in B67283: Diff 162747.Sep 24 2025, 3:55 PM

glebius accepted this revision.Sep 25 2025, 8:22 AM

This revision is now accepted and ready to land.Sep 25 2025, 8:22 AM

Closed by commit rGe05521121f05: ng_tty: copy to the correct mbuf (authored by vexeduxr). · Explain WhySep 25 2025, 4:58 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGe05521121f05: ng_tty: copy to the correct mbuf.

vexeduxr added a commit: rG2ae71a5e9ffb: ng_tty: copy to the correct mbuf.Oct 1 2025, 9:39 AM

vexeduxr added a commit: rGb6ad8caa24c2: ng_tty: copy to the correct mbuf.

vexeduxr added a commit: rG51cac1f186f5: ng_tty: copy to the correct mbuf.

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

2 lines

Diff 162835

sys/netgraph/ng_tty.c

Loading...