net80211: fix possible overflow in IEEE80211_TU_TO_TICKS()
ClosedPublic
Actions

Authored by avos on Feb 13 2016, 9:16 PM.

Details

Reviewers

Commits

rS296393: net80211: fix possible overflow in IEEE80211_TU_TO_TICKS()

Summary

For hz=1000 any number, greater than 4194 causes integer overflow; this change casts the number to uint64_t before operating with it.

Test Plan

Should be reproducible with:
beacon interval: 300
beacon miss threshold: 15

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 13276.Feb 13 2016, 9:16 PM

avos retitled this revision from to net80211: fix possible overflow in IEEE80211_TU_TO_TICKS().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2016, 9:16 PM

avos added a child revision: D5546: rum: add legacy power saving support (STA mode).Mar 4 2016, 12:29 AM

adrian accepted this revision.Mar 4 2016, 1:36 AM

adrian edited edge metadata.

This revision is now accepted and ready to land.Mar 4 2016, 1:36 AM

good catch!

Closed by commit rS296393: net80211: fix possible overflow in IEEE80211_TU_TO_TICKS() (authored by avos). · Explain WhyMar 4 2016, 9:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net80211/

ieee80211_var.h

2 lines

Diff 14085

View Options

head/sys/net80211/ieee80211_var.h

net80211: fix possible overflow in IEEE80211_TU_TO_TICKS()ClosedPublicActions