i'm okay with this here, but the error handling in kernel code does a lot of this kind of thing. That way the unwinding is very clear. If someone edits the code under rum_fail then it has to work correctly in both code paths (success and failure.)

So just be cautious if you decide to do big sweeping changes like this!

This revision is now accepted and ready to land.Mar 10 2016, 5:03 PM

Closed by commit rS297169: rum: simplify error handling in rum_newstate(). (authored by avos). · Explain WhyMar 21 2016, 10:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_rum.c

11 lines

Diff 14492

View Options

head/sys/dev/usb/wlan/if_rum.c

rum: simplify error handling in rum_newstate()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14492

head/sys/dev/usb/wlan/if_rum.c

rum: simplify error handling in rum_newstate()
ClosedPublic
Actions

Revision Contents
Changeset List