Page MenuHomeFreeBSD
Differential D5544

rum: simplify error handling in rum_newstate()
ClosedPublic
Actions

Authored by avos on Mar 4 2016, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 3:53 AM
Unknown Object (File)
Jan 1 2024, 11:18 PM
Unknown Object (File)
Dec 1 2023, 2:58 PM
Unknown Object (File)
Oct 6 2023, 12:24 PM
Unknown Object (File)
Jul 28 2023, 7:15 PM
Unknown Object (File)
Dec 27 2022, 9:26 AM
Unknown Object (File)
Dec 12 2022, 6:49 AM
Unknown Object (File)
Mar 28 2017, 6:58 PM
View All 31 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS297169: rum: simplify error handling in rum_newstate().
Test Plan

Tested with WUSB54GC, STA mode.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 14054.Mar 4 2016, 12:04 AM
avos retitled this revision from to rum: simplify error handling in rum_newstate().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMar 4 2016, 12:04 AM
avos added a child revision: D5546: rum: add legacy power saving support (STA mode).Mar 4 2016, 1:19 AM
adrian accepted this revision.Mar 10 2016, 5:03 PM
adrian edited edge metadata.

i'm okay with this here, but the error handling in kernel code does a lot of this kind of thing. That way the unwinding is very clear. If someone edits the code under rum_fail then it has to work correctly in both code paths (success and failure.)

So just be cautious if you decide to do big sweeping changes like this!

This revision is now accepted and ready to land.Mar 10 2016, 5:03 PM
Closed by commit rS297169: rum: simplify error handling in rum_newstate(). (authored by avos). · Explain WhyMar 21 2016, 10:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
wlan/
11 lines

Diff 14492

View Options

head/sys/dev/usb/wlan/if_rum.c

Loading...