linuxkpi: Move string_helpers.h to string_choices.h
ClosedPublic
Actions

Authored by emaste on Sep 18 2025, 8:55 PM.

Details

Reviewers

dumbbell
bz

Group Reviewers

linuxkpi

Commits

rGfd07941961f9: linuxkpi: Move string_helpers.h to string_choices.h
rG4d6d5f5a21ab: linuxkpi: Move string_helpers.h to string_choices.h

Summary

Chace Linux change fca76071bab2 ("lib/string_helpers: Split out
string_choices.h").  Everything from string_helpers.h that we
implemented has moved, so rename the file, update the include guards,
and add a new dummy string_helpers.h that just #includes it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Sep 18 2025, 8:55 PM

emaste created this revision.

emaste added a reviewer: dumbbell.Sep 18 2025, 9:02 PM

If you can mention v6.5 in the commit message along with the hash; makes it easier to know. But given the change is forward/backward compatible through the include I see no harm.

This revision is now accepted and ready to land.Sep 18 2025, 10:27 PM

Closed by commit rG4d6d5f5a21ab: linuxkpi: Move string_helpers.h to string_choices.h (authored by emaste). · Explain WhySep 19 2025, 1:45 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4d6d5f5a21ab: linuxkpi: Move string_helpers.h to string_choices.h.

Herald added a subscriber: imp. · View Herald TranscriptSep 19 2025, 1:45 AM

emaste added a commit: rGfd07941961f9: linuxkpi: Move string_helpers.h to string_choices.h.Sep 30 2025, 7:25 PM