Details
- Reviewers
wblock lifanov_mail.lifanov.com remko bcr - Group Reviewers
manpages - Commits
- rS295774: - add dma(8) to examples in mailer.conf(5)
mandoc -Tlint (PASS)
man ./mailer.conf.5 (PASS)
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2498 Build 2515: arc lint + arc unit
Event Timeline
.Xr dma 8``` should be added to the See Also list, too. This should not be MFCed, since 10-stable does not have dma.
share/man/man5/mailer.conf.5 | ||
---|---|---|
145 | This is probably better like the comment, "instead of". I suspect that is more common and easier for translators. |
This could be MFC'd with /usr/local/libexec/dma in place of /usr/libexec/dma (as we have mail/dma package).
It's not a big deal if it's mot MFC'd at all though.
I didn't mean to change all of them, but see no problem with that.
Still need to add .Xr dma 8 to the See Also section.
I thought I would be addressing this, but looks like others are now looking into it, as well? I'm not sure what the status of this is now....
Please commandeer this. I'm the reporter from Bugzilla and I had spare cycles to address feedback over the weekend.
It also seems odd to me that we are mentioning the "package from ports"... ports are not packages, and packages are not ports, but you need ports to make packages :)
How about just ommitting the word "package". This becomes "This example shows the use of the mini_sendmail from ports instead of sendmail".
This can be addressed with other content update, in my opinion. I would like to change the wording of the new content, but then go back and address other content.
Since the working is being discussed, I chose a different path as I felt the statement was rather wordy. I attempted to tighten it.
I think "instead of" is more commonly-used than "in place of", but don't have any strong objections.
share/man/man5/mailer.conf.5 | ||
---|---|---|
145 | "in favor of" usually means the second thing is better than/preferred to/replacing the first. It is kind of confusing here. Sometimes difficulty in simplifying a sentence means that it is trying to say to much or working too hard to get there. This example shows how to use .Xr dma 8 as a replacement for .Xr sendmail 8 : That could be even simpler: Using .Xr dma 8 to replace .Xr sendmail 8 : |