Page MenuHomeFreeBSD

Consolidate arm 'standalone' clang flags into bsd.sys.mk
Needs ReviewPublic

Authored by dim on Feb 11 2016, 8:59 PM.

Details

Reviewers
emaste
andrew
imp
Summary

In multiple places, clang flags meant for 'standalone' mode on arm
(disabling movt and fpu instructions) have been duplicated. Since clang
3.8.0 spells the flag to disable movt differently, this became yet a
little uglier.

So let's move the ugliness to bsd.sys.mk, where it (maybe) belongs.
Warner, I think you will have some ideas and directions for this?

In any case, this is simply a draft to get the process going.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2467
Build 2484: arc lint + arc unit

Event Timeline

dim retitled this revision from to Consolidate arm 'standalone' clang flags into bsd.sys.mk.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: imp, emaste, andrew.

I think this is fine, but would like ARM experts to approve.

This patch needs a little rebasing, I'll do that later on.

lib/libstand/Makefile
49–51

Could you add this comment to bsd.sys.mk so we remember why the flags are needed.