Page MenuHomeFreeBSD

vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap()
AcceptedPublic

Authored by kib on Tue, Sep 16, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:21 PM
Unknown Object (File)
Fri, Oct 10, 12:51 PM
Unknown Object (File)
Fri, Oct 10, 12:46 PM
Unknown Object (File)
Fri, Oct 10, 7:45 AM
Unknown Object (File)
Fri, Oct 10, 7:45 AM
Unknown Object (File)
Fri, Oct 10, 7:45 AM
Unknown Object (File)
Fri, Oct 10, 1:46 AM
Unknown Object (File)
Tue, Oct 7, 3:31 PM
Subscribers

Details

Reviewers
alc
markj

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Tue, Sep 16, 3:47 AM
sys/vm/vm_fault.c
714
716–719

or "a fault"

1640

It's not quite true that the caller may hold no locks, e.g., in the TDP_NOFAULTING case the caller may legitimately hold them.

kib marked 3 inline comments as done.

Grammar.
Expand on TDP_NOFAULTING vs. no locks held.

markj added inline comments.
sys/vm/vm_fault.c
1642
This revision is now accepted and ready to land.Tue, Sep 16, 1:31 PM
kib marked an inline comment as done.Tue, Sep 16, 1:33 PM

Even more grammar. Mention m_hold.

This revision now requires review to proceed.Tue, Sep 16, 1:41 PM
This revision is now accepted and ready to land.Tue, Sep 16, 3:04 PM