vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap()
AcceptedPublic
Actions

Authored by kib on Sep 16 2025, 3:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 12, 5:11 AM

	Unknown Object (File)
	Fri, Oct 10, 2:21 PM

	Unknown Object (File)
	Fri, Oct 10, 12:51 PM

	Unknown Object (File)
	Fri, Oct 10, 12:46 PM

	Unknown Object (File)
	Fri, Oct 10, 7:45 AM

	Unknown Object (File)
	Fri, Oct 10, 7:45 AM

	Unknown Object (File)
	Fri, Oct 10, 7:45 AM

	Unknown Object (File)
	Fri, Oct 10, 1:46 AM

View All 27 Files

Subscribers

imp

Details

Reviewers

alc
markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Sep 16 2025, 3:47 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 16 2025, 3:47 AM

kib requested review of this revision.Sep 16 2025, 3:47 AM

markj added inline comments.Sep 16 2025, 1:24 PM

sys/vm/vm_fault.c
714
716–719	or "a fault"
1640	It's not quite true that the caller may hold no locks, e.g., in the TDP_NOFAULTING case the caller may legitimately hold them.

Grammar.
Expand on TDP_NOFAULTING vs. no locks held.

markj accepted this revision.Sep 16 2025, 1:31 PM

markj added inline comments.

sys/vm/vm_fault.c
1642

This revision is now accepted and ready to land.Sep 16 2025, 1:31 PM

kib marked an inline comment as done.Sep 16 2025, 1:33 PM

Even more grammar. Mention m_hold.

This revision now requires review to proceed.Sep 16 2025, 1:41 PM

markj accepted this revision.Tue, Sep 16, 3:04 PM

This revision is now accepted and ready to land.Tue, Sep 16, 3:04 PM

kib mentioned this in rG22cce201da76: vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap().Tue, Sep 16, 4:05 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_fault.c

42 lines

Diff 162149

View Options

vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap()AcceptedPublicActions