Page MenuHomeFreeBSD

bectl: fail if an invalid sort key is used
AcceptedPublic

Authored by kevans on Sep 12 2025, 3:22 PM.
Tags
None
Referenced Files
F132114916: D52498.diff
Mon, Oct 13, 8:43 PM
Unknown Object (File)
Thu, Oct 9, 10:18 PM
Unknown Object (File)
Fri, Oct 3, 2:47 PM
Unknown Object (File)
Thu, Oct 2, 2:15 PM
Unknown Object (File)
Wed, Oct 1, 11:08 AM
Unknown Object (File)
Sat, Sep 27, 2:45 PM
Unknown Object (File)
Tue, Sep 16, 10:17 PM
Unknown Object (File)
Mon, Sep 15, 3:23 PM

Details

Summary

Otherwise we would presumably sort based on garbage. This assumes that
the set of properties fetched for each BE is consistent, thus the
assertion on subsequent nvlist lookups for the sort key.

PR: 266496, 289233
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67012
Build 63895: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 13 2025, 6:23 AM

@kevans can you have a look at your patch in bug 266496? (link)
I think nvlist_lookup_string can also return non-zero if one uses "origin" as key and the boot environment doesn't have an origin data set.

@kevans can you have a look at your patch in bug 266496? (link)
I think nvlist_lookup_string can also return non-zero if one uses "origin" as key and the boot environment doesn't have an origin data set.

You know, I *thought* something about this sounded familiar. *sigh*. That's a fair point re: origin, let me revisit that PR and see what we can do.

Account for origin not existing, use an empty string; add tests

This revision now requires review to proceed.Sep 14 2025, 4:16 PM
This revision is now accepted and ready to land.Mon, Sep 15, 11:44 AM