first cut at reading igb vf stat support

[jmg]

Summary

compile tested, but not run tested

[jmg]

Note that this is only compiled tested. This was mainly to get a preliminary test patch out as it might be a couple days before I can do my own testing, and w/ 15 branch coming up, thought if someone had time to test/look at it in the meantime, we can compress the timeline.

[kbowling]

overall looks fine

sys/dev/e1000/e1000_vf.h

165 ↗

(On Diff #161346)

? Is this the right patch?

sys/dev/e1000/if_em.c

4789

style(9)

[jmg]

sys/dev/e1000/e1000_vf.h

165 ↗

(On Diff #161346)

This header isn't referenced anywhere, so I'm thinking of deleting it. And it's been made mostly redundant by definitions in other headers.

sys/dev/e1000/if_em.c

4789

you mean the space between * and stats;? yeah, I probably copied that from stable/11's version. I'll fix.

[kbowling]

sys/dev/e1000/e1000_vf.h

165 ↗

(On Diff #161346)

That should be done in a separate review and you shouldn't commit this #error b change

sys/dev/e1000/if_em.c

4789

yes

[jmg]

address comments, add comment about union usage

[jmg]

fixed comments, commit message to be:

e1000: fix igb VF stats

igb VF must not read normal stat registers and only read a limited
set of registers.  The PF registers also don't make since as the VF
is an internal port, and there is no PHY to collect stats like CRC
errors from.

PR:     282309
Obtained from:  Juniper Networks, Inc.
Differential Revision:  https://reviews.freebsd.org/D52326

[kgalazka]

@jmg thank you for the patch! I started working on that issue, but a family emergency put me AFK for almost 2 weeks. To avoid further delay I think we should proceed with your version. It looks good to me, but let me run some basic tests on Monday. I'll approve this review as soon as I'm done.

[jmg]

In D52326#1196472, @kgalazka wrote:

@jmg thank you for the patch! I started working on that issue, but a family emergency put me AFK for almost 2 weeks. To avoid further delay I think we should proceed with your version. It looks good to me, but let me run some basic tests on Monday. I'll approve this review as soon as I'm done.

Thanks.

I've tested VF, but haven't been able to test PF as it's an involved process. I assume you'll do this testing on my behalf then and once verified, approve for me to commit?

[jmg]

@kgalazka

ping, any update on this?

Thanks.

[jmg]

We have tested PF, and verified that the sysctls are still there and have not changed.

[kgalazka]

In my testing it also looks good, both on PF and VF.

Once again thank you and my apologies for the delay.