Differential D5226

Set 'laggproto none' on lagg bundle
ClosedPublic
Actions

Authored by pushkarbk_gmail.com on Feb 8 2016, 7:50 AM.

Tags

None

Referenced Files

	F106145413: D5226.diff
	Thu, Dec 26, 3:43 AM

	Unknown Object (File)
	Mon, Dec 9, 10:25 AM

	Unknown Object (File)
	Oct 30 2024, 4:31 PM

	Unknown Object (File)
	Oct 16 2024, 4:19 AM

	Unknown Object (File)
	Oct 1 2024, 3:03 PM

	Unknown Object (File)
	Sep 24 2024, 11:29 PM

	Unknown Object (File)
	Sep 24 2024, 7:01 PM

	Unknown Object (File)
	Sep 21 2024, 2:31 PM

View All 48 Files

Subscribers

None

Details

Reviewers

• rodrigc
lakshmi.n_msystechnologies.com
rpokala
bapt
araujo
gopu.0206_gmail.com

Summary

Command (# ifconfig lagg2 laggproto none) on 11.0-Current results into invalid option.
As per the FreeBSD Lagg man page, 'laggproto none' is a valid configuration option for users.

Attached patch considers 'laggproto none' as a valid configuration option.
i.e 'ifconfig lagg2 laggproto none' command should result into success and should apply 'none' protocol to lagg bundle.

Test Plan

Test Results:

ifconfig lagg2 laggproto none

ifconfig lagg2

lagg2: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=8<VLAN_MTU>
ether 00:0c:29:fb:55:71
nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
media: Ethernet autoselect
status: no carrier
groups: lagg
laggproto none lagghash l2,l3,l4
laggport: le1 flags=0<>
laggport: le2 flags=0<>
laggport: le3 flags=0<>

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

pushkarbk_gmail.com updated this revision to Diff 13110.Feb 8 2016, 7:50 AM

pushkarbk_gmail.com retitled this revision from to Set 'laggproto none' on lagg bundle.

pushkarbk_gmail.com updated this object.

pushkarbk_gmail.com edited the test plan for this revision. (Show Details)

pushkarbk_gmail.com added reviewers: araujo, gopu.0206_gmail.com, rpokala, bapt, lakshmi.n_msystechnologies.com.

gopu.0206_gmail.com accepted this revision.Feb 8 2016, 8:15 AM

gopu.0206_gmail.com edited edge metadata.

This revision is now accepted and ready to land.Feb 8 2016, 8:15 AM

gopu.0206_gmail.com edited edge metadata.Feb 8 2016, 8:17 AM

gopu.0206_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

This patch looks good, I made tests on HEAD and also it gets closest with the patch that we have on 10-Stable.

Best,

I'm gonna wait bapt@ or rodrigc@ approve it too.

Thanks Marcelo.

bapt accepted this revision.Feb 16 2016, 10:36 AM

bapt edited edge metadata.

It was committed already!

Revision Contents
Changeset List

Path

Size

sys/

net/

2 lines

Diff 13110

sys/net/if_lagg.c

Loading...