Page MenuHomeFreeBSD
Differential D52243

arm64: 32-bit compat is little endian, read the correct word
Needs ReviewPublic
Actions

Authored by jmg on Aug 29 2025, 5:24 PM.
Tags
None
Referenced Files
F138912622: D52243.id161201.diff
Fri, Dec 5, 6:49 PM
Unknown Object (File)
Thu, Nov 20, 9:52 PM
Unknown Object (File)
Thu, Nov 20, 9:49 PM
Unknown Object (File)
Thu, Nov 20, 9:40 PM
Unknown Object (File)
Nov 2 2025, 6:17 AM
Unknown Object (File)
Nov 1 2025, 1:10 PM
Unknown Object (File)
Nov 1 2025, 3:27 AM
Unknown Object (File)
Oct 21 2025, 2:06 AM
View All 27 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Summary

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66643
Build 63526: arc lint + arc unit

Event Timeline

jmg created this revision.Aug 29 2025, 5:24 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 29 2025, 5:24 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
jmg requested review of this revision.Aug 29 2025, 5:24 PM
Harbormaster completed remote builds in B66643: Diff 161201.Aug 29 2025, 5:24 PM
jmg added a comment.EditedAug 29 2025, 5:29 PM

The attached program can be used to test/verify the problem/fix. Compile w/ -m32.

I did try to see if I could run a big endian 32-bit binary, but I couldn't figure out how to compile one, plus, we don't ship big endian libraries anyway, so definitely the old code is wrong.

syscalltest.c1 KBDownload

jmg attached a referenced file: F127258092: syscalltest.c. (Show Details)Aug 29 2025, 5:30 PM
andrew added a comment.Thu, Nov 13, 1:57 PM

It looks like this was fixed in 1ca09538d94273601dac08204c1d0b3ca9115864

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines

Diff 161201

View Options

sys/arm64/arm64/elf32_machdep.c

Loading...