nfs client: switch nfs_advlock() to use exclusive vnode lock
ClosedPublic
Actions

Authored by kib on Aug 27 2025, 9:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 3:59 PM

	Unknown Object (File)
	Fri, Oct 10, 3:59 PM

	Unknown Object (File)
	Fri, Oct 10, 3:59 PM

	Unknown Object (File)
	Fri, Oct 10, 9:57 AM

	Unknown Object (File)
	Thu, Oct 9, 5:06 PM

	Unknown Object (File)
	Fri, Oct 3, 5:00 PM

	Unknown Object (File)
	Fri, Oct 3, 12:23 PM

	Unknown Object (File)
	Thu, Oct 2, 3:28 PM

View All 26 Files

Subscribers

imp

Details

Reviewers

rmacklem

Commits

rGfe53e046cd9c: nfs client: switch nfs_advlock() to use exclusive vnode lock

Summary

It eliminates the need to upgrade the lock in the function.
More importantly, the calls to nfs_advlock_p()/nlm_advlock() sometimes
flush buffers, which requires exclusive locking.

Reported by:    bz

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 27 2025, 9:11 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2025, 9:11 PM

kib requested review of this revision.Aug 27 2025, 9:11 PM

Looks fine to me.

This revision is now accepted and ready to land.Aug 27 2025, 10:32 PM

Closed by commit rGfe53e046cd9c: nfs client: switch nfs_advlock() to use exclusive vnode lock (authored by kib). · Explain WhyAug 27 2025, 10:37 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGfe53e046cd9c: nfs client: switch nfs_advlock() to use exclusive vnode lock.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsclient/

nfs_clvnops.c

7 lines

Diff 161093

View Options

sys/fs/nfsclient/nfs_clvnops.c

nfs client: switch nfs_advlock() to use exclusive vnode lockClosedPublicActions