Page MenuHomeFreeBSD

vchiq_arm: Don't free on error
ClosedPublic

Authored by imp on Aug 25 2025, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 20, 6:46 AM
Unknown Object (File)
Sun, Sep 20, 6:45 AM
Unknown Object (File)
Thu, Sep 17, 5:39 PM
Unknown Object (File)
Tue, Sep 15, 10:54 PM
Unknown Object (File)
Thu, Sep 10, 4:55 PM
Unknown Object (File)
Wed, Sep 9, 8:42 PM
Unknown Object (File)
Tue, Sep 8, 4:38 AM
Unknown Object (File)
Sat, Sep 5, 1:22 PM
Subscribers
None

Details

Summary

When actual_pages is -1, calling vm_page_unhold_pages will loop
forever. We don't actually need to loop. In fact, it will either be -1
or the right number of pages: we never return a partial allocation. It
might be more proper to assert this, but since this is contrib code,
make a minimal change to avoid the infinite loop.

Sponsored by: Netflix

Test Plan

I have no way of testing this, but the code is clearly wrong when vm_fault_quick_hold_pages returns -1.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable