Page MenuHomeFreeBSD

vop_fsync_debugprepost(): take account of nullfs
ClosedPublic

Authored by kib on Aug 4 2025, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 9 2025, 11:51 PM
Unknown Object (File)
Dec 5 2025, 9:46 PM
Unknown Object (File)
Oct 25 2025, 3:40 AM
Unknown Object (File)
Oct 24 2025, 4:17 AM
Unknown Object (File)
Oct 17 2025, 5:30 AM
Unknown Object (File)
Oct 10 2025, 5:28 PM
Unknown Object (File)
Oct 10 2025, 5:28 PM
Unknown Object (File)
Oct 10 2025, 5:28 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Aug 4 2025, 8:13 PM

I reproduced the problem using a -o nocache nullfs mount, since that disables writing with shared locks held (why?). This patch fixes the crash.

This revision is now accepted and ready to land.Aug 4 2025, 10:02 PM

I reproduced the problem using a -o nocache nullfs mount, since that disables writing with shared locks held (why?).

Because with nocache we are guaranteed that new nullfs vnode must be instantiated with each bypass call. That requires the lower vnode to be locked exclusively.

This revision was automatically updated to reflect the committed changes.