vop_fsync_debugprepost(): take account of nullfs
ClosedPublic
Actions

Authored by kib on Aug 4 2025, 8:13 PM.

Tags

None

Referenced Files

	F132472531: D51730.id159730.diff
	Fri, Oct 17, 5:30 AM

	Unknown Object (File)
	Fri, Oct 10, 5:28 PM

	Unknown Object (File)
	Fri, Oct 10, 5:28 PM

	Unknown Object (File)
	Fri, Oct 10, 5:28 PM

	Unknown Object (File)
	Fri, Oct 10, 12:18 PM

	Unknown Object (File)
	Wed, Oct 8, 9:31 PM

	Unknown Object (File)
	Tue, Oct 7, 10:38 AM

	Unknown Object (File)
	Fri, Oct 3, 2:21 PM

View All 25 Files

Subscribers

imp

olce

Details

Reviewers

markj

Commits

rGfd50bb3f7cd0: vop_fsync_debugprepost(): take account of nullfs

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 4 2025, 8:13 PM

Herald added subscribers: olce, imp. · View Herald TranscriptAug 4 2025, 8:13 PM

kib requested review of this revision.Aug 4 2025, 8:13 PM

I reproduced the problem using a -o nocache nullfs mount, since that disables writing with shared locks held (why?). This patch fixes the crash.

This revision is now accepted and ready to land.Aug 4 2025, 10:02 PM

In D51730#1181610, @markj wrote:

I reproduced the problem using a -o nocache nullfs mount, since that disables writing with shared locks held (why?).

Because with nocache we are guaranteed that new nullfs vnode must be instantiated with each bypass call. That requires the lower vnode to be locked exclusively.

Closed by commit rGfd50bb3f7cd0: vop_fsync_debugprepost(): take account of nullfs (authored by kib). · Explain WhyAug 4 2025, 10:27 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGfd50bb3f7cd0: vop_fsync_debugprepost(): take account of nullfs.