libarchive: Stop using readdir_r()
ClosedPublic
Actions

Authored by des on Aug 1 2025, 4:17 PM.

Details

Reviewers

Group Reviewers

Commits

rG83e2f9e1c0cf: libarchive: Stop using readdir_r()
rG9ddbef8a3a82: libarchive: Stop using readdir_r()
rG01e42ce81f75: libarchive: Stop using readdir_r()

Summary

It cannot be used safely, though libarchive goes to ridiculous lengths
to attempt to do so.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65896
Build 62779: arc lint + arc unit

Event Timeline

des created this revision.Aug 1 2025, 4:17 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2025, 4:17 PM

des requested review of this revision.Aug 1 2025, 4:17 PM

Harbormaster completed remote builds in B65896: Diff 159579.Aug 1 2025, 4:17 PM

des added a parent revision: D51678: bsnmpd: Fix an error message.Aug 1 2025, 4:17 PM

des added a child revision: D51680: kyua: Stop using readdir_r().

markj accepted this revision as: markj.Aug 1 2025, 9:03 PM

This revision is now accepted and ready to land.Aug 1 2025, 9:03 PM

Perhaps also reference upstream PR?

Closed by commit rG01e42ce81f75: libarchive: Stop using readdir_r() (authored by des). · Explain WhyAug 1 2025, 11:14 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG01e42ce81f75: libarchive: Stop using readdir_r().

des added a commit: rG9ddbef8a3a82: libarchive: Stop using readdir_r().Aug 8 2025, 10:10 PM

des added a commit: rG83e2f9e1c0cf: libarchive: Stop using readdir_r().

Revision Contents
Changeset List

Path

Size

lib/

libarchive/

config_freebsd.h

1 line

Diff 159579

View Options

lib/libarchive/config_freebsd.h

libarchive: Stop using readdir_r()ClosedPublicActions