amd64/pmap: include opt_kstack_pages.h

[khng]

Summary

This fixes an early KASAN initialization panic in pmap_san_enter_early_alloc_4k, when a non-default value
is specified for KSTACK_PAGES in the build config file.

Sponsored by: Juniper Networks, Inc.

[markj]

But that use of KSTACK_PAGES matches the definition of BOOTSTACK_SIZE in amd64/locore.S, which also doesn't include opt_kstack_pages.h. So both files should include it.

[khng]

In D51676#1180379, @markj wrote:

But that use of KSTACK_PAGES matches the definition of BOOTSTACK_SIZE in amd64/locore.S, which also doesn't include opt_kstack_pages.h. So both files should include it.

It should be fine. KSTACK_PAGES is defined in ${OBJTOP}/sys/GENERIC-KASAN/assym.inc rather.

[markj]

In D51676#1180380, @khng wrote:

In D51676#1180379, @markj wrote:

But that use of KSTACK_PAGES matches the definition of BOOTSTACK_SIZE in amd64/locore.S, which also doesn't include opt_kstack_pages.h. So both files should include it.

It should be fine. KSTACK_PAGES is defined in ${OBJTOP}/sys/GENERIC-KASAN/assym.inc rather.

Ok. It still doesn't hurt to include it explicitly, like arm64/locore.S does.

[khng]

markj's suggestion.

[markj]

Seems ok to me. The tag in the commit title should just be "amd64: ..." now.

[des]

In D51676#1180433, @markj wrote:

Ok. It still doesn't hurt to include it explicitly, like arm64/locore.S does.

It absolutely does hurt. Breaks the build, actually. Please revert.