Differential D51652

LinuxKPI: pci: use unsigned int for vendor/device arguemnts
ClosedPublic
Actions

Authored by bz on Jul 31 2025, 7:29 AM.

Details

Reviewers

emaste

Group Reviewers

linuxkpi

Commits

rGa96486531b91: LinuxKPI: pci: use unsigned int for vendor/device arguments

Summary

Linux drivers may pass a typed PCI_ANY_ID (-1U) in which then leads
to a warning that the value gets truncated. Switch argument types
to unsigned int (or uint32_t as we use in struct pci_device_id) to
avoid the problem.

Sponsored by: The FreeBSD Foundation
Discussed in: D50008
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65862
Build 62745: arc lint + arc unit

Event Timeline

bz created this revision.Jul 31 2025, 7:29 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 31 2025, 7:29 AM

Harbormaster completed remote builds in B65862: Diff 159488.Jul 31 2025, 7:29 AM

bz requested review of this revision.Jul 31 2025, 7:29 AM

emaste accepted this revision as: emaste.Jul 31 2025, 10:27 AM

This revision is now accepted and ready to land.Jul 31 2025, 10:27 AM

Closed by commit rGa96486531b91: LinuxKPI: pci: use unsigned int for vendor/device arguments (authored by bz). · Explain WhyJul 31 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGa96486531b91: LinuxKPI: pci: use unsigned int for vendor/device arguments.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

pci.h

4 lines

src/

linux_pci.c

2 lines

Diff 159488

View Options

sys/compat/linuxkpi/common/include/linux/pci.h