A classic Lode Runner game remake heavily based on LodeRunner_TotalRecall
implementation by Simon Hung.
Details
- Reviewers
dch - Group Reviewers
Ports Committers
- Built and run on Honeycomb LX2 (aarch64) with Xfce4;
- Built and run on ThinkPad X230 (amd64) with Xfce4.
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment out this line, https://github.com/vchimishuk/loderunner-ng/blob/master/CMakeLists.txt#L24
Does it pass Poudriere on 13.5, and 14.3? (i386 and amd64)?
games/loderunner-ng/Makefile | ||
---|---|---|
10 | Define LICENSE_FILE | |
12 | Is :insource needed? |
Okay, will do.
Does it pass Poudriere on 13.5, and 14.3? (i386 and amd64)?
I built it on Poudriere 14.2-RELEASE (amd64) and 14.3-STABLE (aarch64). Will try those today evening.
games/loderunner-ng/Makefile | ||
---|---|---|
12 | Yes, according to the author |
Successfully compiled on:
- i386, 13.5-RELEASE, 14.3-RELEASE
- amd64, 13.5-RELEASE, 14.3-RELEASE
- aarch64, 13.5-RELEASE, 14.3-RELEASE
games/loderunner-ng/Makefile | ||
---|---|---|
12 | Can be built out-of-source starting from 0.1.3. |
games/loderunner-ng/Makefile | ||
---|---|---|
10 | Done |
2 small things, fix these & you're good to commit IMO:
[pre-commit] ERROR: Missing 'SUBDIR += loderunner-ng' in games/Makefile
portclippy wants USE_SDL to go after GH_ACCOUNT:
$ portclippy --strict Makefile # PORTNAME block PORTNAME DISTVERSION CATEGORIES # Maintainer block MAINTAINER COMMENT WWW # License block LICENSE LICENSE_FILE # USES block USES -USE_SDL USE_GITHUB GH_ACCOUNT +USE_SDL
LGTM and I am *very excited* about this port. So many memories!
I'd argue that portclippy is wrong, don't mix GITHUB with the rest of USES section it makes harder to follow and preferably put it in a separate section below like in Porters Handbook.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
games/loderunner-ng/Makefile | ||
---|---|---|
13 | Just a reminder SDL2 is likely to be deprecated upstream given that SDL3 is our and there's a compat lib |