Differential D51599

stand/i386: Don't include SASRC in .PATH of boot loaders
ClosedPublic
Actions

Authored by jhb on Jul 28 2025, 4:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 9, 1:15 AM

	Unknown Object (File)
	Thu, Jan 29, 5:01 AM

	Unknown Object (File)
	Thu, Jan 29, 5:01 AM

	Unknown Object (File)
	Dec 28 2025, 10:44 PM

	Unknown Object (File)
	Dec 18 2025, 4:48 AM

	Unknown Object (File)
	Dec 14 2025, 2:29 PM

	Unknown Object (File)
	Dec 12 2025, 1:36 AM

	Unknown Object (File)
	Dec 6 2025, 2:58 AM

View All 41 Files

Subscribers

Details

Reviewers

imp
manu

Commits

rGdf607c941f88: stand/i386: Don't include SASRC in .PATH of boot loaders

Summary

These link against libsa instead of pulling individual sources from
the libsa source directory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 28 2025, 4:15 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 28 2025, 4:15 PM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jul 28 2025, 4:15 PM

jhb added a parent revision: D51598: stand/i386: Remove references to empty variable OPENCRYPTO_XTS.

Harbormaster completed remote builds in B65808: Diff 159339.Jul 28 2025, 4:15 PM

Historically, we pulled individual files in from SASRC. However, at some point, we started pulling in libsa.a more generally and stopped listing the individual files.

imp accepted this revision.Jul 28 2025, 5:43 PM

This revision is now accepted and ready to land.Jul 28 2025, 5:43 PM

Yes, the last one might have been util.o which was around the time you were cleaning up the GELI boot stuff, but I didn't try to narrow it down to exactly which commit removed the last use.

Closed by commit rGdf607c941f88: stand/i386: Don't include SASRC in .PATH of boot loaders (authored by jhb). · Explain WhyJul 28 2025, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdf607c941f88: stand/i386: Don't include SASRC in .PATH of boot loaders.

Revision Contents
Changeset List

Path

Size

stand/

i386/

gptboot/

2 lines

isoboot/

2 lines

Diff 159356

stand/i386/gptboot/Makefile

Loading...

stand/i386/isoboot/Makefile

Loading...