Page MenuHomeFreeBSD
Differential D51533

vmm: Clean up legacy create/destroy interface
ClosedPublic
Actions

Authored by emaste on Jul 25 2025, 5:26 PM.
Tags
None
Referenced Files
F172696340: D51533.diff
Sun, Sep 20, 7:48 AM
Unknown Object (File)
Tue, Sep 1, 4:01 PM
Unknown Object (File)
Tue, Sep 1, 3:58 PM
Unknown Object (File)
Tue, Sep 1, 3:35 PM
Unknown Object (File)
Tue, Sep 1, 3:49 AM
Unknown Object (File)
Sat, Aug 29, 3:36 AM
Unknown Object (File)
Aug 13 2026, 12:17 AM
Unknown Object (File)
Aug 11 2026, 11:14 PM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
jhb
Group Reviewers
bhyve
Commits
rG7507d6ca0e75: vmm: Clean up legacy create/destroy interface
Summary

Add sysctl descriptions, and remove surprising default text.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jul 25 2025, 5:26 PM
emaste created this revision.
markj added a subscriber: markj.Jul 25 2025, 5:30 PM
markj added inline comments.
sys/dev/vmm/vmm_dev.c
822–823

You can just remove this line, buf is allocated with M_ZERO.

910–911

Same here.

920
emaste updated this revision to Diff 159109.Jul 25 2025, 5:33 PM

update with @markj feedback

markj accepted this revision as: markj.Jul 25 2025, 5:34 PM
This revision is now accepted and ready to land.Jul 25 2025, 5:34 PM
jhb accepted this revision.Jul 25 2025, 9:22 PM
Closed by commit rG7507d6ca0e75: vmm: Clean up legacy create/destroy interface (authored by emaste). · Explain WhyJul 26 2025, 10:52 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG7507d6ca0e75: vmm: Clean up legacy create/destroy interface.
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2025, 10:52 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vmm/
6 lines

Diff 159214

View Options

sys/dev/vmm/vmm_dev.c

Loading...