+ Rework synopsis for consistency
+ Add a HARDWARE section for HW relnotes
+ tag SPDX
MFC after: 3 days
Differential D51240
snd_uaudio.4: Rework SYNOPSIS, add HARDWARE, SPDX ziaee on Jul 10 2025, 11:21 PM. Authored by Tags None Referenced Files
Subscribers
Details
+ Rework synopsis for consistency MFC after: 3 days
Diff Detail
Event Timeline
Comment Actions Remove duplicate text from introductory sentence, thanks. I still need some advice on the unset value in SYNOPSIS? Comment Actions I am actually not sure why we need to show default values in the SYNOPSIS section. As is explained in SYSCTL VARIABLES, sometimes a value of 0 has special meaning. I am actually not sure of the advantage of including those in the SYNOPSIS in the first place, since we enumerate right below almost. But if we are to list them, I do not think we should provide values as well.
Comment Actions That sounds good. You're right, utilities don't list valid arguments Comment Actions Please note that snd_uaudio(4) can also create some sysctls under dev.pcm.*, that is, dev.pcm.%d.mixer (along with sub-sysctls) and dev.pcm.%d.feedback_rate. The former is documented in BUGS (for some reason), and the latter is not documented at all.
Comment Actions LGTM, but I think we should also document the dev.pcm.* controls I mentioned in my last comment. Comment Actions Other than bumping Dd (and maybe adding the missing sysctls), LGTM.
Comment Actions Thanks so much for your attention to this matter. I'm going to add them in an immediate followup review! Comment Actions
Thanks for sharing, haven't seen this video clip before. I fully agree and like the useful, concise mtw(4) example, please keep it up! |