Page MenuHomeFreeBSD
Differential D5119

Minor clean-ups for ARM64 GICv3 and GIC drivers
ClosedPublic
Actions

Authored by zbb on Jan 29 2016, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 1:53 PM
Unknown Object (File)
Mar 1 2024, 11:04 AM
Unknown Object (File)
Feb 7 2024, 3:20 PM
Unknown Object (File)
Feb 7 2024, 2:45 PM
Unknown Object (File)
Jan 10 2024, 10:39 PM
Unknown Object (File)
Jan 9 2024, 11:09 AM
Unknown Object (File)
Jan 9 2024, 11:08 AM
Unknown Object (File)
Dec 27 2023, 8:27 PM
View All 44 Files
Subscribers
emaste
arm64

Details

Reviewers
wma
andrew
imp
Commits
rS295512: Minor clean-ups for ARM64 GICv3 and GIC drivers
Summary

GICv3:

  • move ICC_SGI1R_EL1 definitions to armreg.h and use proper system register's names

GIC:

  • remove unused functions

Reviewed by:
Obtained from: Semihalf
Sponsored by: Cavium
Differential Revision:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zbb updated this revision to Diff 12831.Jan 29 2016, 6:10 PM
zbb retitled this revision from to Minor clean-ups for ARM64 GICv3 and GIC drivers.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: andrew, wma, imp.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.
zbb added a subscriber: arm64.
Herald added a subscriber: emaste. · View Herald TranscriptJan 29 2016, 6:10 PM
andrew added inline comments.Jan 29 2016, 7:09 PM
sys/arm64/include/armreg.h
123–124 ↗(On Diff #12831)

These two should be moved up so we order by shift value.

Also there is no need for the braces around any of these, other than the shifted value below.

zbb updated this revision to Diff 12931.Feb 1 2016, 2:50 PM
zbb marked an inline comment as done.
andrew accepted this revision.Feb 1 2016, 4:31 PM
andrew edited edge metadata.
This revision is now accepted and ready to land.Feb 1 2016, 4:31 PM
Closed by commit rS295512: Minor clean-ups for ARM64 GICv3 and GIC drivers (authored by zbb). · Explain WhyFeb 11 2016, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
arm64/
23 lines
11 lines
6 lines
include/
9 lines

Diff 13217

View Options

head/sys/arm64/arm64/gic.c

Loading...
View Options

head/sys/arm64/arm64/gic_v3.c

Loading...
View Options

head/sys/arm64/arm64/gic_v3_reg.h

Loading...
View Options

head/sys/arm64/include/armreg.h

Loading...