Page MenuHomeFreeBSD

scandir: Propagate errors from readdir().
ClosedPublic

Authored by des on Jun 25 2025, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 1, 3:58 AM
Unknown Object (File)
Fri, May 29, 9:24 PM
Unknown Object (File)
Fri, May 29, 3:43 AM
Unknown Object (File)
Thu, May 28, 2:31 PM
Unknown Object (File)
Thu, May 28, 9:05 AM
Unknown Object (File)
Wed, May 27, 2:01 AM
Unknown Object (File)
Sun, May 24, 8:55 PM
Unknown Object (File)
May 16 2026, 3:36 AM
Subscribers

Details

Summary

Currently, if readdir() fails, scandir() simply returns a partial
result (or a null result if it fails before any entries were selected).
There is no way within the current API design to return both a partial
result and an error indicator, so err on the side of caution: if an
error occurs, discard any partial result and return the error instead.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jun 25 2025, 8:11 PM
This revision is now accepted and ready to land.Jun 25 2025, 8:28 PM
This revision now requires review to proceed.Jun 25 2025, 8:43 PM
This revision is now accepted and ready to land.Jun 25 2025, 8:50 PM
This revision was automatically updated to reflect the committed changes.