Paths

Table of Contentst

Differential D51046

scandir: Propagate errors from readdir().
ClosedPublic
Actions

Authored by des on Jun 25 2025, 8:11 PM.

Tags

None

Referenced Files

	F151213799: D51046.diff
	Mon, Apr 6, 9:34 PM

	F151160789: D51046.id157623.diff
	Mon, Apr 6, 12:35 PM

	F151155877: D51046.id157651.diff
	Mon, Apr 6, 11:48 AM

	F151112971: D51046.diff
	Mon, Apr 6, 4:06 AM

	Unknown Object (File)
	Sun, Apr 5, 3:54 PM

	Unknown Object (File)
	Sun, Apr 5, 5:42 AM

	Unknown Object (File)
	Sat, Mar 28, 1:17 AM

	Unknown Object (File)
	Tue, Mar 17, 4:54 PM

View All 55 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG1a3c32bac0f0: scandir: Propagate errors from readdir().
rG62e0f12f5104: scandir: Propagate errors from readdir().

Summary

Currently, if readdir() fails, scandir() simply returns a partial
result (or a null result if it fails before any entries were selected).
There is no way within the current API design to return both a partial
result and an error indicator, so err on the side of caution: if an
error occurs, discard any partial result and return the error instead.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 25 2025, 8:11 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptJun 25 2025, 8:11 PM

des requested review of this revision.Jun 25 2025, 8:11 PM

Harbormaster completed remote builds in B65087: Diff 157618.Jun 25 2025, 8:11 PM

markj accepted this revision as: markj.Jun 25 2025, 8:28 PM

This revision is now accepted and ready to land.Jun 25 2025, 8:28 PM

remove style changes

This revision now requires review to proceed.Jun 25 2025, 8:43 PM

Harbormaster completed remote builds in B65091: Diff 157623.Jun 25 2025, 8:43 PM

des added a child revision: D51050: scandir: Code cleanup..Jun 25 2025, 8:44 PM

markj accepted this revision as: markj.Jun 25 2025, 8:50 PM

This revision is now accepted and ready to land.Jun 25 2025, 8:50 PM

Closed by commit rG62e0f12f5104: scandir: Propagate errors from readdir(). (authored by des). · Explain WhyJun 26 2025, 7:38 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG62e0f12f5104: scandir: Propagate errors from readdir()..

des added a commit: rG1a3c32bac0f0: scandir: Propagate errors from readdir()..Feb 5 2026, 3:27 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

32 lines

12 lines

tests/

gen/

63 lines

Diff 157651

lib/libc/gen/scandir.3

Loading...

lib/libc/gen/scandir.c

Loading...

lib/libc/tests/gen/scandir_test.c

Loading...