With Linux 6.9, pm_runtime_get_if_active() lost its second bool argument.
This change is put behind a check of LINUXKPI_VERSION to keep compatibility.
Sponsored by: The FreeBSD Foundation
Details
Details
- Reviewers
bz - Group Reviewers
linuxkpi - Commits
- rG1609b4d45610: linuxkpi: Add `pm_runtime_get_if_active()` variant from Linux 6.9
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/compat/linuxkpi/common/include/linux/pm_runtime.h | ||
|---|---|---|
| 37 | I would always keep the current version in the default and the legacy version under ifdef. Question is, does drm-kmod define LINUXKPI_VERSION for each release it is doing. If so, I see see no in-kernel consumers so should be fine. | |
| sys/compat/linuxkpi/common/include/linux/pm_runtime.h | ||
|---|---|---|
| 37 | You already told me something similar but couldn’t remember the advice… It took an example in another file and replicated it. drm-kmod always define LINUXKPI_VERSION. At least, that’s the first commit I make when I start a new port. | |
Comment Actions
Address comment from @bz: default the #if/#else logic to the latest version. A user has to define LINUXKPI_VERSION to request the older variant.