Page MenuHomeFreeBSD
Differential D50843

vt_fb: account for endianness
ClosedPublic
Actions

Authored by vexeduxr on Jun 14 2025, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 6:52 PM
Unknown Object (File)
Thu, Oct 23, 1:12 PM
Unknown Object (File)
Fri, Oct 3, 3:15 PM
Unknown Object (File)
Sep 20 2025, 8:29 PM
Unknown Object (File)
Sep 16 2025, 11:50 AM
Unknown Object (File)
Sep 15 2025, 4:36 PM
Unknown Object (File)
Sep 15 2025, 2:19 AM
Unknown Object (File)
Sep 8 2025, 6:21 PM
View All 39 Files
Subscribers
None

Details

Reviewers
imp
manu
kevans
Commits
rGb2e0dfc808c1: vt_fb: account for endianness
Summary

Account for endianness when writing to 24bpp framebuffers. Also create a
vt_fb_mem_wr3 function to avoid code duplication.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64864
Build 61747: arc lint + arc unit

Event Timeline

vexeduxr requested review of this revision.Jun 14 2025, 12:47 PM
vexeduxr created this revision.
Harbormaster completed remote builds in B64864: Diff 157019.Jun 14 2025, 12:47 PM
vexeduxr added a parent revision: D50842: vt_fb: fix KASSERTs.Jun 14 2025, 12:47 PM
vexeduxr added a comment.Jun 14 2025, 12:49 PM

QEMU seems to give us a 24bpp framebuffer only when using the CSM firmware. This can be tested by loading QEMU with the CSM firmware then booting through UEFI.

imp accepted this revision.Jun 21 2025, 9:22 PM
This revision is now accepted and ready to land.Jun 21 2025, 9:22 PM
vexeduxr added reviewers: manu, kevans.Jun 22 2025, 3:30 AM
manu accepted this revision.Jun 22 2025, 6:25 AM
Closed by commit rGb2e0dfc808c1: vt_fb: account for endianness (authored by vexeduxr). · Explain WhyJun 23 2025, 6:27 AM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGb2e0dfc808c1: vt_fb: account for endianness.

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
fb/
33 lines

Diff 157019

View Options

sys/dev/vt/hw/fb/vt_fb.c

Loading...