sysent: retire unused SV_IA32
ClosedPublic
Actions

Authored by brooks on Jun 3 2025, 10:22 PM.

Details

Reviewers

Commits

rG503f752a347f: sysent: retire unused SV_IA32

Summary

When COMPAT_IA32 was generaliaed to COMPAT_FREEBSD32 in 2010 (commit
841c0c7ec75b), all runtime uses of SV_IA32 were removed in favor of
SV_ILP32 check. Given SV_ILP32's existance it makes no
sense to dynamically check for SV_IA32 (even if we had a 32-bit x86 ABI
with 64-bit time_t we needed to differentiate, SV_IA32 would be the
wrong spelling.) As such, remove SV_IA32 and mark it reserved.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Jun 3 2025, 10:22 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJun 3 2025, 10:22 PM

brooks requested review of this revision.Jun 3 2025, 10:22 PM

Harbormaster completed remote builds in B64623: Diff 156495.Jun 3 2025, 10:22 PM

I don't feel particularly strongly about this change, but noticed we're running short SV_ bits and this one isn't doing anything. We're currently consuming two more in CheriBSD and we'd want at least one of them when we merge CHERI support.

kib accepted this revision.Jun 3 2025, 10:55 PM

This revision is now accepted and ready to land.Jun 3 2025, 10:55 PM

Closed by commit rG503f752a347f: sysent: retire unused SV_IA32 (authored by brooks). · Explain WhyJun 3 2025, 11:02 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG503f752a347f: sysent: retire unused SV_IA32.