cp: Fix copying to root directory.
ClosedPublic
Actions

Authored by des on May 30 2025, 9:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 10, 8:43 AM

	Unknown Object (File)
	Mon, Dec 8, 8:54 PM

	Unknown Object (File)
	Sat, Dec 6, 2:22 AM

	Unknown Object (File)
	Tue, Dec 2, 8:11 PM

	Unknown Object (File)
	Tue, Nov 25, 8:55 PM

	Unknown Object (File)
	Oct 29 2025, 9:38 PM

	Unknown Object (File)
	Oct 29 2025, 3:52 AM

	Unknown Object (File)
	Oct 29 2025, 3:52 AM

View All 42 Files

Subscribers

imp

Details

Reviewers

allanjude

Group Reviewers

Klara

Commits

rG537fbf70f12b: cp: Fix copying to root directory.

Summary

The trailing-slash logic would strip the target down to an empty
string, which we would then fail to stat, and subsequently attempt
(and fail) to create.

Fixes: 82fc0d09e862
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 30 2025, 9:11 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2025, 9:11 AM

des requested review of this revision.May 30 2025, 9:11 AM

Harbormaster completed remote builds in B64545: Diff 156291.May 30 2025, 9:11 AM

allanjude accepted this revision as: allanjude.May 30 2025, 2:08 PM

This revision is now accepted and ready to land.May 30 2025, 2:08 PM

Closed by commit rG537fbf70f12b: cp: Fix copying to root directory. (authored by des). · Explain WhyMay 30 2025, 3:45 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG537fbf70f12b: cp: Fix copying to root directory..

Revision Contents
Changeset List

Path

Size

bin/

cp/

cp.c

12 lines

tests/

cp_test.sh

22 lines

Diff 156301

View Options

bin/cp/cp.c