Page MenuHomeFreeBSD

Makefile.inc1: Remove packagekernel non-NO_ROOT support
ClosedPublic

Authored by emaste on May 15 2025, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 2:13 AM
Unknown Object (File)
Thu, Sep 25, 5:29 PM
Unknown Object (File)
Wed, Sep 24, 2:58 PM
Unknown Object (File)
Sep 13 2025, 12:59 PM
Unknown Object (File)
Sep 4 2025, 6:16 PM
Unknown Object (File)
Aug 13 2025, 9:38 PM
Unknown Object (File)
Aug 9 2025, 3:21 AM
Unknown Object (File)
Jul 29 2025, 4:29 AM
Subscribers

Details

Summary
As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") the other code path is unused, so remove it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
Makefile.inc1
1969

The difference between the now-removed block and the above is that the NO_ROOT case uses kernel.meta previously generated by distributekernel (tar @kernel.meta) vs tar . here.

Just remove the .if defined(NO_ROOT) -- packagekernel requires that distributekernel was run first, and distributekernel always generates a metalog.

Makefile.inc1
1967

this is just a nit in the diff output - there's still a .endif here; the diff just shows the one now at line 1973 as the one that remains.

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2025, 9:51 PM
This revision was automatically updated to reflect the committed changes.