Differential D49897

riscv: Fix handling of interrupts during kernel page faults
ClosedPublic
Actions

Authored by markj on Apr 18 2025, 8:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 20, 6:52 AM

	Unknown Object (File)
	Sat, Nov 15, 11:33 PM

	Unknown Object (File)
	Wed, Nov 5, 3:51 AM

	Unknown Object (File)
	Oct 26 2025, 12:18 AM

	Unknown Object (File)
	Oct 25 2025, 4:41 AM

	Unknown Object (File)
	Oct 25 2025, 2:32 AM

	Unknown Object (File)
	Oct 19 2025, 8:44 AM

	Unknown Object (File)
	Oct 19 2025, 12:02 AM

View All 48 Files

Subscribers

Details

Reviewers

br
mhorne
jrtc27

Group Reviewers

Commits

rGdfbda7c53d67: riscv: Fix handling of interrupts during kernel page faults
rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults

Summary

We were checking the wrong status bit when deciding whether to enable
interrupts.

Fixes: c226f193515c ("riscv: Permit spurious faults in kernel mode")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 18 2025, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2025, 8:35 PM

markj requested review of this revision.Apr 18 2025, 8:35 PM

Harbormaster completed remote builds in B63582: Diff 153889.Apr 18 2025, 8:35 PM

Oh, yes, I failed to spot that in the review but this was clearly wrong and a no-op

This revision is now accepted and ready to land.Apr 18 2025, 9:07 PM

Closed by commit rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults (authored by markj). · Explain WhyApr 19 2025, 10:42 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0ca5e3dd1ad0: riscv: Fix handling of interrupts during kernel page faults.

markj added a commit: rGdfbda7c53d67: riscv: Fix handling of interrupts during kernel page faults.Apr 29 2025, 12:48 AM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

riscv/

2 lines

Diff 153946

sys/riscv/riscv/trap.c

Loading...