Paths

Table of Contentst

Differential D49808

linuxkpi: Factorize the computation of timeout in `linux_schedule.c`
AbandonedPublic
Actions

Authored by dumbbell on Apr 13 2025, 10:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 14, 12:26 AM

	Unknown Object (File)
	Tue, Nov 11, 12:09 AM

	Unknown Object (File)
	Mon, Nov 10, 10:55 PM

	Unknown Object (File)
	Mon, Nov 10, 5:11 PM

	Unknown Object (File)
	Mon, Nov 10, 3:23 PM

	Unknown Object (File)
	Mon, Nov 10, 11:57 AM

	Unknown Object (File)
	Wed, Nov 5, 11:05 PM

	Unknown Object (File)
	Sat, Nov 1, 6:29 AM

View All 48 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

The same logic was repeated three times.

This is part of the update of DRM drivers to Linux 6.7. This is a follow-up to D48755.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Apr 13 2025, 10:04 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 13 2025, 10:04 AM

dumbbell requested review of this revision.Apr 13 2025, 10:04 AM

dumbbell edited the summary of this revision. (Show Details)

dumbbell mentioned this in D48755: linuxkpi: Add `woken_wake_function()` and `wait_woken()` .Apr 13 2025, 10:15 AM

markj accepted this revision.Apr 15 2025, 1:37 PM

This revision is now accepted and ready to land.Apr 15 2025, 1:37 PM

Factorize the computation of the expiry time and the remainder. They will be used in D48755.

This revision now requires review to proceed.Apr 19 2025, 2:00 PM

markj accepted this revision.Apr 26 2025, 3:17 PM

This revision is now accepted and ready to land.Apr 26 2025, 3:17 PM

markj added inline comments.Apr 29 2025, 2:56 PM

sys/compat/linuxkpi/common/src/linux_schedule.c
74	I just realized that this will conflict with commit 325aa4dbd10d04a61a9529e1d76212b5649b3c73, sorry. In general we need to switch to using `unsigned long` for jiffies values, like Linux does.

dumbbell marked an inline comment as done.May 8 2025, 9:24 AM

dumbbell mentioned this in D50192: linuxkpi: Fix up jiffies handling.May 8 2025, 10:02 AM

Mostly covered by D50192.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_schedule.c

69 lines

Diff 153915

sys/compat/linuxkpi/common/src/linux_schedule.c

Loading...