Note that '-r' expects a hashtag instead of a group name.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
tools/tools/git/git-arc.1 | ||
---|---|---|
87 | Hashtag is from social media and kind of slang. How do you feel about: Addl. Context: https://en.m.wikipedia.org/wiki/Number_sign |
Maybe we don't even have to bloat it at all and could make it clear by simply saying:
"Each argument must be an existing Phabricator user or #group."
tools/tools/git/git-arc.1 | ||
---|---|---|
87 | I opted for "hashtag" since it was already used in one of the examples below, IMO it makes the expected format very clear. |
tools/tools/git/git-arc.1 | ||
---|---|---|
85–88 | Adding a sentence and a parenthetical does make it clear, but it adds a lot of complexity. Would it be clear if we improved the first sentence instead, without adding complexity? |
tools/tools/git/git-arc.1 | ||
---|---|---|
85–88 |
I think this is fine. A larger improvement would be to sync the usage message and man page, which give similar but not identical content and examples.