Page MenuHomeFreeBSD
Differential D4954

AXP209 Power Management Unit
ClosedPublic
Actions

Authored by manu_bidouilliste.com on Jan 15 2016, 1:51 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Nov 24, 10:12 AM
Unknown Object (File)
Sun, Nov 24, 1:15 AM
Unknown Object (File)
Sat, Nov 23, 5:51 AM
Unknown Object (File)
Sat, Nov 23, 2:51 AM
Unknown Object (File)
Thu, Nov 21, 6:13 AM
Unknown Object (File)
Wed, Nov 20, 5:02 AM
Unknown Object (File)
Wed, Nov 13, 6:57 PM
Unknown Object (File)
Fri, Nov 8, 6:37 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
andrew
Group Reviewers
Contributor Reviews (src)
Commits
rS295634: Add support for the AXP209 Power System Management IC. This allows boards
Summary

Basic support for the AXP209 found in board with A10 and A20 SoC.
It prints in dmesg what is the source of power (AC, USB, Battery) and shutdown the SoC at shutdown

Test Plan

Apply I2C patch (review D4846)
Apply patch and build kernel
Verify that the board correctly shutdown when 'shutdown -p now'

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu_bidouilliste.com updated this revision to Diff 12357.Jan 15 2016, 1:51 PM
manu_bidouilliste.com retitled this revision from to AXP209 Power Management Unit.
manu_bidouilliste.com updated this object.
manu_bidouilliste.com edited the test plan for this revision. (Show Details)
manu_bidouilliste.com set the repository for this revision to rS FreeBSD src repository - subversion.
manu_bidouilliste.com added a project: ARM.
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJan 15 2016, 1:51 PM
Herald added subscribers: andrew, imp. · View Herald Transcript
andrew added inline comments.Jan 18 2016, 2:29 PM
sys/arm/allwinner/axp209.c
124–126 ↗(On Diff #12357)

This should move to the attach function.

130 ↗(On Diff #12357)

You should return BUS_PROBE_DEFAULT here.

137 ↗(On Diff #12357)

This looks like odd indentation

143 ↗(On Diff #12357)

What are these magic values?

146 ↗(On Diff #12357)

I think this should be under bootverbose.

sys/arm/allwinner/files.allwinner
17 ↗(On Diff #12357)

the sorting on this file is a little off

manu_bidouilliste.com updated this revision to Diff 12469.Jan 19 2016, 1:47 PM
manu_bidouilliste.com edited edge metadata.

Only printf messages when in bootverbose.
Get our i2c addr in attach instead of probe.
Explain the bit logic to find the power source.

manu_bidouilliste.com marked 6 inline comments as done.Jan 19 2016, 1:49 PM

The new diff handle all your remarks (I hope)

andrew added inline comments.Jan 19 2016, 4:15 PM
sys/arm/allwinner/axp209.c
126 ↗(On Diff #12469)

You're still setting this in the probe function. Its doesn't seem to be used so could be removed

150 ↗(On Diff #12469)

Google thinks register 0x00 is the Power State Register, it would be nice if there was a macro for this, e.g.

#define AXP209_PSR 0x00
koobs edited reviewers, added: Contributor Reviews (src); removed: Contributor Reviewers (ports).Jan 20 2016, 6:26 AM
manu_bidouilliste.com updated this revision to Diff 12521.Jan 20 2016, 4:39 PM

Add register defines
Remove dev from softc since we don't need it.

manu_bidouilliste.com marked 2 inline comments as done.Jan 20 2016, 4:39 PM

Last comment are now fixed.

manu_bidouilliste.com updated this revision to Diff 13127.Feb 8 2016, 3:09 PM

Rename driver to axp209_pmu
As driver name ends with number it is not really pretty to have axp2090 in dmesg.

andrew added inline comments.Feb 13 2016, 1:58 PM
sys/arm/allwinner/axp209.c
55 ↗(On Diff #13127)

#define<tab>AXP...

56–57 ↗(On Diff #13127)

s/REG00/PSR/g (and below with REG32 -> SHUTBAT)

153 ↗(On Diff #13127)

How long is this line? It's difficult to tell if it's past the 80 character limit.

manu_bidouilliste.com updated this revision to Diff 13274.Feb 13 2016, 5:48 PM
Rename register define to have name instead of reg number.
Fix style(9)
manu_bidouilliste.com marked 3 inline comments as done.Feb 13 2016, 5:48 PM
manu_bidouilliste.com updated this revision to Diff 13325.Feb 15 2016, 3:34 PM

Update diff because of recent -HEAD change.
Also add axp209 to A10 kernel config file.

andrew accepted this revision.Feb 15 2016, 7:02 PM
andrew added a reviewer: andrew.

There are a few style(9) issues, but I'll fix them before committing.

This revision is now accepted and ready to land.Feb 15 2016, 7:02 PM
Closed by commit rS295634: Add support for the AXP209 Power System Management IC. This allows boards (authored by andrew). · Explain WhyFeb 15 2016, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
182 lines
1 line

Diff 13331

View Options

head/sys/arm/allwinner/axp209.c

Loading...
View Options

head/sys/arm/allwinner/files.allwinner

Loading...