Page MenuHomeFreeBSD
Differential D49206

amd64 csu: microoptimize startup
ClosedPublic
Actions

Authored by kib on Mar 3 2025, 12:02 AM.
Tags
None
Referenced Files
F132407502: D49206.diff
Thu, Oct 16, 4:32 PM
Unknown Object (File)
Sat, Oct 11, 3:02 AM
Unknown Object (File)
Wed, Oct 8, 2:44 PM
Unknown Object (File)
Wed, Oct 8, 2:43 PM
Unknown Object (File)
Wed, Oct 8, 10:07 AM
Unknown Object (File)
Mon, Oct 6, 2:32 AM
Unknown Object (File)
Wed, Oct 1, 2:27 AM
Unknown Object (File)
Mon, Sep 29, 7:31 PM
View All 62 Files
Subscribers
imp

Details

Reviewers
jhb
markj
emaste
Commits
rGcb991a228179: amd64 csu: microoptimize startup
Summary

Reorder operations to reduce moving the values among registers.
Use the LEA instruction to combine arithmetic with the moves.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Mar 3 2025, 12:02 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2025, 12:02 AM
kib requested review of this revision.Mar 3 2025, 12:02 AM
kib updated this revision to Diff 151763.Mar 3 2025, 4:38 AM

Correct the offset of env.

markj added inline comments.Mar 3 2025, 8:01 AM
lib/csu/amd64/crt1_s.S
53

What is *apl?

55

Shouldn't the comment say + 2?

kib updated this revision to Diff 151771.Mar 3 2025, 8:26 AM
kib marked 2 inline comments as done.

Fix typos in comments.

markj accepted this revision.Mar 3 2025, 11:22 AM
This revision is now accepted and ready to land.Mar 3 2025, 11:22 AM
Closed by commit rGcb991a228179: amd64 csu: microoptimize startup (authored by kib). · Explain WhyMar 4 2025, 4:25 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGcb991a228179: amd64 csu: microoptimize startup.

Revision Contents
Changeset List

PathSize
lib/
csu/
amd64/
15 lines

Diff 151829

View Options

lib/csu/amd64/crt1_s.S

Loading...