Page MenuHomeFreeBSD
Differential D49206

amd64 csu: microoptimize startup
AcceptedPublic
Actions

Authored by kib on Mon, Mar 3, 12:02 AM.

Details

Reviewers
jhb
markj
emaste
Summary

Reorder operations to reduce moving the values among registers.
Use the LEA instruction to combine arithmetic with the moves.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Mon, Mar 3, 12:02 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 3, 12:02 AM
kib requested review of this revision.Mon, Mar 3, 12:02 AM
kib updated this revision to Diff 151763.Mon, Mar 3, 4:38 AM

Correct the offset of env.

markj added inline comments.Mon, Mar 3, 8:01 AM
lib/csu/amd64/crt1_s.S
53

What is *apl?

55

Shouldn't the comment say + 2?

kib updated this revision to Diff 151771.Mon, Mar 3, 8:26 AM
kib marked 2 inline comments as done.

Fix typos in comments.

markj accepted this revision.Mon, Mar 3, 11:22 AM
This revision is now accepted and ready to land.Mon, Mar 3, 11:22 AM

Revision Contents
Changeset List

PathSize
lib/
csu/
amd64/
15 lines

Diff 151771

View Options

lib/csu/amd64/crt1_s.S

Loading...