Page MenuHomeFreeBSD
Differential D49114

Mk/bsd.options.desc.mk: Use proper name for HTTP/2
ClosedPublic
Actions

Authored by michaelo on Feb 23 2025, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 12:28 AM
Unknown Object (File)
Fri, Sep 26, 8:06 PM
Unknown Object (File)
Fri, Sep 26, 2:24 AM
Unknown Object (File)
Thu, Sep 25, 2:31 AM
Unknown Object (File)
Thu, Sep 25, 2:31 AM
Unknown Object (File)
Thu, Sep 25, 2:30 AM
Unknown Object (File)
Thu, Sep 25, 2:30 AM
Unknown Object (File)
Thu, Sep 25, 2:29 AM
View All 71 Files
Subscribers
None

Details

Reviewers
jrm
otis
diizzy
rene
Group Reviewers
portmgr
Commits
R11:111fab8011ea: Mk/bsd.options.desc.mk: Use proper name for HTTP/2
Summary

The protocol is officially called HTTP/2 in RFC 9113, old drafts used 2.0 which
were obsoleted.

Approved by: jrm (mentor), otis (mentor), ...

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Feb 23 2025, 5:56 PM
michaelo created this revision.
Harbormaster completed remote builds in B62599: Diff 151377.Feb 23 2025, 5:56 PM
michaelo added a reviewer: portmgr.Feb 23 2025, 5:57 PM
jrm added a comment.Feb 23 2025, 6:03 PM

There are a few other instances of HTTP/2.0 in the tree.

% rg -F 'HTTP/2.0'
Mk/bsd.options.desc.mk
165:HPACK_DESC?=                Header Compression for HTTP/2.0 support

www/wget2/Makefile
68:NGHTTP2_DESC=                Support HTTP/2.0 through libnghttp2

www/libnghttp2/Makefile
8:COMMENT=      HTTP/2.0 C Library

www/nghttp2/Makefile
7:COMMENT=      HTTP/2.0 C Library

www/linux-rl9-libnghttp2/Makefile
8:COMMENT=      HTTP/2.0 C Library (Rocky Linux ${LINUX_DIST_VER})
michaelo added a comment.Feb 24 2025, 7:54 AM
In D49114#1119986, @jrm wrote:

There are a few other instances of HTTP/2.0 in the tree.

% rg -F 'HTTP/2.0'
Mk/bsd.options.desc.mk
165:HPACK_DESC?=                Header Compression for HTTP/2.0 support

www/wget2/Makefile
68:NGHTTP2_DESC=                Support HTTP/2.0 through libnghttp2

www/libnghttp2/Makefile
8:COMMENT=      HTTP/2.0 C Library

www/nghttp2/Makefile
7:COMMENT=      HTTP/2.0 C Library

www/linux-rl9-libnghttp2/Makefile
8:COMMENT=      HTTP/2.0 C Library (Rocky Linux ${LINUX_DIST_VER})

Good catch, but I will handle nghttp2 and its consumers separately because it requires some analysis. Apparently both curl and wget us libnghttp2, but the descriptions do not consistently crom the Mk/.

michaelo updated this revision to Diff 151390.Feb 24 2025, 7:55 AM

Incorporate jrm's comments

Harbormaster completed remote builds in B62607: Diff 151390.Feb 24 2025, 7:55 AM
michaelo mentioned this in D49118: www/{lib,}nghttp2: Improve descriptions.Feb 24 2025, 8:17 AM
michaelo updated this revision to Diff 151394.Feb 24 2025, 8:18 AM

Move libnghttp2 for Linux to D49118

Harbormaster completed remote builds in B62611: Diff 151394.Feb 24 2025, 8:18 AM
michaelo added a comment.Mar 4 2025, 8:04 AM

Folks, any objections?

rene accepted this revision.Mar 4 2025, 7:07 PM
This revision is now accepted and ready to land.Mar 4 2025, 7:07 PM
jrm accepted this revision.Mar 4 2025, 7:09 PM
Closed by commit R11:111fab8011ea: Mk/bsd.options.desc.mk: Use proper name for HTTP/2 (authored by michaelo). · Explain WhyMar 6 2025, 9:32 AM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:111fab8011ea: Mk/bsd.options.desc.mk: Use proper name for HTTP/2.
michaelo mentioned this in R11:4fc8ab499f44: www/{lib,}nghttp2: Improve descriptions.Mar 10 2025, 12:07 PM

Revision Contents
Changeset List

PathSize
Mk/
4 lines

Diff 151950

View Options

Mk/bsd.options.desc.mk

Loading...