Page MenuHomeFreeBSD
Differential D49072

Document EACCES in ioctl(2).
ClosedPublic
Actions

Authored by felix.the.red_gmail.com on Feb 20 2025, 6:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 26, 4:33 PM
Unknown Object (File)
Mon, Dec 8, 11:13 PM
Unknown Object (File)
Nov 28 2025, 9:22 AM
Unknown Object (File)
Nov 21 2025, 7:56 PM
Unknown Object (File)
Nov 9 2025, 2:32 AM
Unknown Object (File)
Nov 2 2025, 12:46 AM
Unknown Object (File)
Nov 1 2025, 3:00 AM
Unknown Object (File)
Oct 28 2025, 3:50 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
ziaee
Group Reviewers
manpages
Commits
rGe2afbc45258f: ioctl.2: Mention EACCES
Summary

Add documentation for error code EACCES when calling
ioctl(2).

Test Plan

PR:239504

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

felix.the.red_gmail.com created this revision.Feb 20 2025, 6:55 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2025, 6:55 AM
felix.the.red_gmail.com requested review of this revision.Feb 20 2025, 6:55 AM
Harbormaster completed remote builds in B62537: Diff 151233.Feb 20 2025, 6:56 AM
felix.the.red_gmail.com edited the test plan for this revision. (Show Details)Feb 20 2025, 6:59 AM
ziaee added a comment.EditedFeb 20 2025, 1:53 PM

Looks great! Tip, you want the PR in the summary with a colon in the middle. The test plan field is something different, more like "git-arc.sh patch -c D49072; grep ioctl.c eaccess; mandoc -Tlint" etc.

lib/libsys/ioctl.2
114

I'd remove this line, the second line is already perfect. It even has the search keyword "permission"

ziaee added inline comments.Feb 21 2025, 4:27 PM
lib/libsys/ioctl.2
115

If ever writing the title of the page, use the name macro instead.

ziaee added a comment.May 19 2025, 11:14 PM

Meow

ziaee added a comment.Jun 13 2025, 1:45 PM

nudge

felix.the.red_gmail.com updated this revision to Diff 157487.Jun 24 2025, 12:52 AM
felix.the.red_gmail.com edited the test plan for this revision. (Show Details)

Removed Permission denied sentence.

ziaee accepted this revision.Mon, Dec 29, 7:26 PM

Merging, thanks Felix! Sorry I forgot about this one earlier!

lib/libsys/ioctl.2
115

I'm going to just fix this upon commit.

This revision is now accepted and ready to land.Mon, Dec 29, 7:26 PM
Closed by commit rGe2afbc45258f: ioctl.2: Mention EACCES (authored by felix.the.red_gmail.com, committed by ziaee). · Explain WhyMon, Dec 29, 7:28 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rGe2afbc45258f: ioctl.2: Mention EACCES.

Revision Contents
Changeset List

PathSize
lib/
libsys/
5 lines

Diff 168736

View Options

lib/libsys/ioctl.2

Loading...