Track mbuf owner
Needs ReviewPublic
Actions

Authored by darius-dons.net.au on Jan 13 2016, 4:36 AM.

Details

Reviewers

None

Group Reviewers

Contributor Reviews (src)

Summary

This patch is a re-implementation of Isilon's mbuf tracking code which shows records who owns a given mbuf. It has a sysctl which produces a summary of how many buffers are owned by each.
It also adds a 'show mbuf' command to DDB.

The magic/ugliness is that it has x86 only code to look at the stack and find the caller of the mbuf function to record it as the owner.

Test Plan

Booted up a VM and run..
ls -laR / > /dev/null & sysctl kern.ipc.mbufs

a few times

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

darius-dons.net.au updated this revision to Diff 12229.Jan 13 2016, 4:36 AM

darius-dons.net.au retitled this revision from to Track mbuf owner.

darius-dons.net.au updated this object.

darius-dons.net.au edited the test plan for this revision. (Show Details)

darius-dons.net.au set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJan 13 2016, 4:36 AM

Herald added a subscriber: imp. · View Herald Transcript

koobs edited reviewers, added: Contributor Reviews (src); removed: Contributor Reviewers (ports).Jan 20 2016, 6:27 AM

cem added a subscriber: cem.May 3 2016, 6:26 PM

cem added inline comments.

sys/x86/include/stack.h
54–74	Why not use the GCC function `__builtin_return_address()` instead? That should be somewhat portable to non-x86? https://gcc.gnu.org/onlinedocs/gcc/Return-Address.html Clang/LLVM support the macros as well (for X86 since LLVM2.5): https://github.com/llvm-mirror/clang/blob/master/test/Sema/builtin-stackaddress.c