Page MenuHomeFreeBSD
Differential D4900

kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT
ClosedPublic
Actions

Authored by vangyzen on Jan 12 2016, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 4:48 PM
Unknown Object (File)
Sat, Sep 5, 1:56 PM
Unknown Object (File)
Sat, Sep 5, 1:51 PM
Unknown Object (File)
Sat, Sep 5, 3:39 AM
Unknown Object (File)
Fri, Sep 4, 7:40 PM
Unknown Object (File)
Thu, Sep 3, 11:09 PM
Unknown Object (File)
Thu, Sep 3, 5:06 AM
Unknown Object (File)
Wed, Sep 2, 8:04 PM
View All Files
Subscribers
dab
imp
jhb

Details

Reviewers
jmg
Commits
rS295012: kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT
Summary

NOTE_CHILD and NOTE_EXIT return something in kevent.data: the parent
pid (ppid) for NOTE_CHILD and the exit status for NOTE_EXIT.
Do not let the two events be combined, since one would overwrite
the other's data.

PR: 180385
MFC after: 2 weeks
Submitted by: David A. Bright <david_a_bright@dell.com>
Sponsored by: Dell Inc.

Test Plan

A unit test is included.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vangyzen updated this revision to Diff 12217.Jan 12 2016, 7:42 PM
vangyzen retitled this revision from to kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT.
vangyzen updated this object.
vangyzen edited the test plan for this revision. (Show Details)
Herald added a reviewer: jmg. · View Herald TranscriptJan 12 2016, 7:42 PM
Herald added a subscriber: imp. · View Herald Transcript
vangyzen updated this object.Jan 12 2016, 7:44 PM
vangyzen edited edge metadata.
jhb added a subscriber: jhb.Jan 12 2016, 8:28 PM

On the surface I think this looks good. Keeping NOTE_CHILD and NOTE_EXIT separate is definitely the right approach to avoid losing data.

tests/sys/kqueue/proc.c
98 ↗(On Diff #12217)

I would probably say that a pipe() is best for a test, even if it is more work than a bare sleep().

194 ↗(On Diff #12217)

s/CHILD/EXIT/

vangyzen updated this revision to Diff 12225.Jan 13 2016, 1:38 AM

Use a pipe, instead of sleeping, for process synchronization.

Fix a copy-and-paste-o.

vangyzen added inline comments.Jan 13 2016, 1:40 AM
tests/sys/kqueue/proc.c
98 ↗(On Diff #12225)

Agreed. In fact, the code that found this uses a pipe.

dab added a subscriber: dab.Jan 19 2016, 3:59 PM
Closed by commit rS295012: kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT (authored by vangyzen). · Explain WhyJan 28 2016, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
61 lines
sys/
1 line
tests/
sys/
kqueue/
1 line
75 lines
168 lines

Diff 12802

View Options

head/sys/kern/kern_event.c

Loading...
View Options

head/sys/sys/event.h

Loading...
View Options

head/tests/sys/kqueue/common.h

Loading...
View Options

head/tests/sys/kqueue/main.c

Loading...
View Options

head/tests/sys/kqueue/proc.c

Loading...