Page MenuHomeFreeBSD
Differential D48980

net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
ClosedPublic
Actions

Authored by bz on Thu, Feb 13, 1:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 10:43 AM
Unknown Object (File)
Fri, Feb 21, 4:15 PM
Unknown Object (File)
Fri, Feb 21, 1:18 PM
Unknown Object (File)
Fri, Feb 21, 6:38 AM
Unknown Object (File)
Thu, Feb 20, 10:43 PM
Unknown Object (File)
Mon, Feb 17, 9:48 AM
Subscribers
adrian
glebius
imp
melifaro

Details

Reviewers
adrian
Group Reviewers
wireless
Commits
rG6ddcff36f154: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix
Summary

For ieee80211_node_delucastkey() rather than checking the keyix to be
IEEE80211_KEYIX_NONE use the IEEE80211_KEY_UNDEFINED() macro (which
chekes the wk_cipher to be 'none').

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Thu, Feb 13, 1:45 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptThu, Feb 13, 1:45 AM
bz requested review of this revision.Thu, Feb 13, 1:45 AM
Harbormaster completed remote builds in B62413: Diff 150940.Thu, Feb 13, 1:45 AM
bz added a comment.Thu, Feb 13, 1:47 AM

The follow-up logic seems to be an ath(4)-only case so it might be worth double-checking that there is no undocumented condition that made the key check here being done as it was. If you accept this review please state that it seems fine in comment as well.

adrian accepted this revision.Thu, Feb 13, 2:14 AM
adrian added a subscriber: adrian.

it doesn't surprise me if ti's ath(4) only as well, that and wi is where this all started.

We should go document some actual correct usage of this so we know what / when to expect stuff.

This revision is now accepted and ready to land.Thu, Feb 13, 2:14 AM
Closed by commit rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix (authored by bz). · Explain WhySat, Feb 15, 3:52 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG9763fec11b83: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.
bz added a commit: rG6ddcff36f154: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.Mon, Feb 24, 8:28 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
2 lines

Diff 151079

View Options

sys/net80211/ieee80211_node.c

Loading...