mfc-candidates: Annotate variables as local
AbandonedPublic
Actions

Authored by markj on Feb 11 2025, 10:56 PM.

Details

Reviewers

emaste

Summary

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62453
Build 59337: arc lint + arc unit

Event Timeline

markj created this revision.Feb 11 2025, 10:56 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 10:56 PM

markj requested review of this revision.Feb 11 2025, 10:56 PM

Harbormaster completed remote builds in B62377: Diff 150864.Feb 11 2025, 10:56 PM

markj added a child revision: D48951: mfc-candidates: Fix remote repo detection.Feb 11 2025, 10:56 PM

emaste accepted this revision.Feb 12 2025, 2:57 AM

This revision is now accepted and ready to land.Feb 12 2025, 2:57 AM

jlduran added a subscriber: jlduran.Feb 14 2025, 5:25 PM

jlduran added inline comments.

tools/tools/git/mfc-candidates.lua
128	Just to silence the remaining luacheck warning.

Remove some unneeded initializations.

This revision now requires review to proceed.Feb 14 2025, 8:08 PM

Harbormaster completed remote builds in B62453: Diff 151054.Feb 14 2025, 8:08 PM

emaste accepted this revision.Feb 14 2025, 8:11 PM

This revision is now accepted and ready to land.Feb 14 2025, 8:11 PM

I've been using git-mfc instead, which I think has a superset of the functionality in mfc-candidates.

Revision Contents
Changeset List

Path

Size

tools/

git/

mfc-candidates.lua

12 lines

Diff 151054

View Options

tools/tools/git/mfc-candidates.lua

mfc-candidates: Annotate variables as localAbandonedPublicActions