Paths

Table of Contentst

Differential D48857

Mk/Uses/samba.mk: Introduce 3 new SAMBA_*_PORT variables
ClosedPublic
Actions

Authored by yasu on Feb 5 2025, 6:04 AM.

Tags

None

Referenced Files

	F139442360: D48857.diff
	Fri, Dec 12, 3:33 AM

	Unknown Object (File)
	Fri, Dec 5, 4:49 AM

	Unknown Object (File)
	Fri, Dec 5, 4:49 AM

	Unknown Object (File)
	Wed, Dec 3, 10:31 PM

	Unknown Object (File)
	Thu, Nov 20, 11:14 PM

	Unknown Object (File)
	Thu, Nov 20, 11:13 PM

	Unknown Object (File)
	Thu, Nov 20, 11:11 PM

	Unknown Object (File)
	Thu, Nov 20, 11:03 PM

View All 54 Files

Subscribers

None

Details

Reviewers

0mp
kiwi
mikael
timur

Commits

R11:88122c70b358: Mk/Uses/samba.mk: Introduce 3 new SAMBA_*_PORT variables

Summary

Introduce 3 new variable, SAMBA_TALLOC_PORT, SAMBA_TDB_PORT and SAMBA_TEVENT_PORT. Proper port origin ("databases/ldb29" for example) is assigned to them depending on the value of SAMBA_DEFAULT. They are intended to be used by ports that works with Samba to specify proper version of talloc, tdb and/or tevent as dependency.
Add item in CHANGES.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 62266
Build 59150: arc lint + arc unit

Event Timeline

yasu requested review of this revision.Feb 5 2025, 6:04 AM

yasu created this revision.

Harbormaster completed remote builds in B62266: Diff 150514.Feb 5 2025, 6:05 AM

A couple of grammar nits. Otherwise, lgtm.

CHANGES
22
23
29	Suggestion: That's probably a minor thing, but maybe `samba:env` would fit this example better.
31
32

This revision is now accepted and ready to land.Feb 5 2025, 9:12 AM

kiwi accepted this revision.Feb 5 2025, 9:36 AM

Closed by commit R11:88122c70b358: Mk/Uses/samba.mk: Introduce 3 new SAMBA_*_PORT variables (authored by yasu). · Explain WhyFeb 6 2025, 5:14 AM

This revision was automatically updated to reflect the committed changes.

yasu added a commit: R11:88122c70b358: Mk/Uses/samba.mk: Introduce 3 new SAMBA_*_PORT variables.

Revision Contents
Changeset List

Path

Size

21 lines

Mk/

Uses/

12 lines

Diff 150514

CHANGES

Loading...

Mk/Uses/samba.mk

Loading...