Page MenuHomeFreeBSD

libvmmapi: Fix auto-loading of vmm.ko
Needs ReviewPublic

Authored by markj on Sun, Feb 2, 9:45 PM.
Tags
None
Referenced Files
F109311369: D48797.id150380.diff
Mon, Feb 3, 10:13 AM
F109304470: D48797.diff
Mon, Feb 3, 7:54 AM
F109301326: D48797.diff
Mon, Feb 3, 6:56 AM
Subscribers

Details

Reviewers
jhb
Group Reviewers
bhyve
Summary
  • We should autoload vmm.ko when creating a VM with vm_openf(), to preserve behaviour prior to commit 99127fd10362.
  • kldload(2) returns a non-zero value upon success, so the existing code was wrong.

Reported by: olivier
Fixes: 99127fd10362 ("libvmmapi: Use the vmmctl device file to create and destroy VMs")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62208
Build 59092: arc lint + arc unit

Event Timeline

markj requested review of this revision.Sun, Feb 2, 9:45 PM

I don't really like the auto-loading, but that's how it used to work, and changing it in 15.0 would be a POLA violation.