Page MenuHomeFreeBSD

linuxkpi: Include <linux/{types,io}.h> from <video/vga.h>
ClosedPublic

Authored by dumbbell on Jan 31 2025, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 16 2025, 6:36 AM
Unknown Object (File)
Sep 15 2025, 7:47 AM
Unknown Object (File)
Sep 14 2025, 8:19 PM
Unknown Object (File)
Sep 8 2025, 11:29 PM
Unknown Object (File)
Aug 19 2025, 9:11 PM
Unknown Object (File)
Aug 11 2025, 3:47 PM
Unknown Object (File)
Aug 5 2025, 11:57 AM
Unknown Object (File)
Aug 2 2025, 1:50 AM
Subscribers

Details

Summary

Why

Some files in the i915 DRM driver in Linux 6.7 depend on these implicit inclusions.

This is part of the update of DRM drivers to Linux 6.7.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 31 2025, 2:37 PM

Also, please do *NOT* commit this (or any other) with *WHY* as the subject line of the commit message. each commit should have a single line at the top that describes the whole commit.
This is true for the whole series. Also I think I saw a *HOW* heading, that should be omitted as well and the context should make it clear to match our usual practice.

In D48751#1112293, @imp wrote:

Also, please do *NOT* commit this (or any other) with *WHY* as the subject line of the commit message. each commit should have a single line at the top that describes the whole commit.
This is true for the whole series. Also I think I saw a *HOW* heading, that should be omitted as well and the context should make it clear to match our usual practice.

I’m sorry, I did not notice your message before pushing the patches… I use the revision title as the commit’s first line. When I put why/how headers, there are in the "body" of the commit message.

From now on, I will not include these headers.

In D48751#1112293, @imp wrote:

Also, please do *NOT* commit this (or any other) with *WHY* as the subject line of the commit message. each commit should have a single line at the top that describes the whole commit.
This is true for the whole series. Also I think I saw a *HOW* heading, that should be omitted as well and the context should make it clear to match our usual practice.

I’m sorry, I did not notice your message before pushing the patches… I use the revision title as the commit’s first line. When I put why/how headers, there are in the "body" of the commit message.

From now on, I will not include these headers.

Perfect. I kinda thought that might have happened, so I said the same thing elsewhere... not a big deal going forward