Page MenuHomeFreeBSD

mixer(3): Do not skip devices with no volume control
ClosedPublic

Authored by christos on Jan 30 2025, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 1:53 PM
Unknown Object (File)
Wed, Sep 24, 3:27 AM
Unknown Object (File)
Tue, Sep 16, 3:23 AM
Unknown Object (File)
Sep 12 2025, 2:50 PM
Unknown Object (File)
Sep 4 2025, 7:24 PM
Unknown Object (File)
Aug 9 2025, 8:58 AM
Unknown Object (File)
Aug 7 2025, 5:49 PM
Unknown Object (File)
Aug 6 2025, 10:40 PM
Subscribers

Details

Summary

Some devices might not have a software volume control, but still be
able to be set as recording sources.

PR: 279787
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos retitled this revision from mixer(3): Do not skip recording-only devices to mixer(3): Do not skip devices with no volume control.Feb 1 2025, 11:08 AM
christos edited the summary of this revision. (Show Details)

Thanks for updating the title, I was confused by this originally

lib/libmixer/mixer.c
124

Probably worth a comment here explaining why we allow failure. Or maybe if (_mixer_readvol(dp) < 0 && MIX_ISDEV(m, i))?

This revision is now accepted and ready to land.Feb 3 2025, 12:21 PM
christos marked an inline comment as done.

Address Ed's comment.

This revision now requires review to proceed.Feb 3 2025, 1:25 PM

Ah yes, that's even better

This revision is now accepted and ready to land.Feb 3 2025, 2:47 PM