Page MenuHomeFreeBSD

kern_sysctl: Fix sysctl leaf re-use warnings
ClosedPublic

Authored by zlei on Jan 23 2025, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 5:03 PM
Unknown Object (File)
Fri, Feb 28, 4:52 PM
Unknown Object (File)
Thu, Feb 27, 9:54 AM
Unknown Object (File)
Thu, Feb 27, 7:07 AM
Unknown Object (File)
Sun, Feb 23, 9:39 PM
Unknown Object (File)
Sat, Feb 22, 9:58 AM
Unknown Object (File)
Sun, Feb 9, 5:23 PM
Unknown Object (File)
Sat, Feb 8, 11:38 PM
Subscribers

Details

Summary

The original PR 221853 actually requested to distinguish which function (the caller) emits the re-use warning, while the implementation sysctl_warn_reuse() has the parameter func (function name ) passed in but not used. That renders the warning message less useful.

Fix: 4ae2ade11426 Enhance debugibility of sysctl leaf re-use warnings
MFC after: 1 week

Test Plan

Before this change:

# sysctl sysctl.reuse_test
sysctl_warn_reuse: can't re-use a leaf (sysctl.reuse_test)!

After the change:

# sysctl sysctl.reuse_test
sysctl_reuse_test: can't re-use a leaf (sysctl.reuse_test)!

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable