Page MenuHomeFreeBSD

kern_sysctl: Fix sysctl leaf re-use warnings
ClosedPublic

Authored by zlei on Jan 23 2025, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 24, 3:03 PM
Unknown Object (File)
Thu, Mar 19, 4:04 AM
Unknown Object (File)
Mon, Mar 16, 2:49 AM
Unknown Object (File)
Sun, Mar 15, 9:06 AM
Unknown Object (File)
Sun, Mar 8, 6:59 AM
Unknown Object (File)
Sun, Mar 8, 6:41 AM
Unknown Object (File)
Feb 9 2026, 8:17 AM
Unknown Object (File)
Jan 31 2026, 2:37 AM
Subscribers

Details

Summary

The original PR 221853 actually requested to distinguish which function (the caller) emits the re-use warning, while the implementation sysctl_warn_reuse() has the parameter func (function name ) passed in but not used. That renders the warning message less useful.

Fix: 4ae2ade11426 Enhance debugibility of sysctl leaf re-use warnings
MFC after: 1 week

Test Plan

Before this change:

# sysctl sysctl.reuse_test
sysctl_warn_reuse: can't re-use a leaf (sysctl.reuse_test)!

After the change:

# sysctl sysctl.reuse_test
sysctl_reuse_test: can't re-use a leaf (sysctl.reuse_test)!

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable