Page MenuHomeFreeBSD

kern_sysctl: Fix sysctl leaf re-use warnings
ClosedPublic

Authored by zlei on Jan 23 2025, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 10:40 PM
Unknown Object (File)
Sat, Oct 11, 12:18 PM
Unknown Object (File)
Wed, Oct 1, 1:10 AM
Unknown Object (File)
Sun, Sep 14, 5:28 PM
Unknown Object (File)
Sat, Sep 13, 11:16 AM
Unknown Object (File)
Sep 5 2025, 6:16 AM
Unknown Object (File)
Sep 3 2025, 7:39 PM
Unknown Object (File)
Sep 3 2025, 12:35 PM
Subscribers

Details

Summary

The original PR 221853 actually requested to distinguish which function (the caller) emits the re-use warning, while the implementation sysctl_warn_reuse() has the parameter func (function name ) passed in but not used. That renders the warning message less useful.

Fix: 4ae2ade11426 Enhance debugibility of sysctl leaf re-use warnings
MFC after: 1 week

Test Plan

Before this change:

# sysctl sysctl.reuse_test
sysctl_warn_reuse: can't re-use a leaf (sysctl.reuse_test)!

After the change:

# sysctl sysctl.reuse_test
sysctl_reuse_test: can't re-use a leaf (sysctl.reuse_test)!

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable