Page MenuHomeFreeBSD

sound tests: Fix 32bit calculation detection in pcm_read_write
ClosedPublic

Authored by dev_submerge.ch on Jan 23 2025, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 25, 5:32 AM
Unknown Object (File)
Tue, Oct 14, 4:49 PM
Unknown Object (File)
Thu, Oct 2, 2:11 AM
Unknown Object (File)
Sep 17 2025, 2:03 PM
Unknown Object (File)
Sep 7 2025, 11:45 PM
Unknown Object (File)
Aug 26 2025, 1:36 AM
Unknown Object (File)
Aug 21 2025, 10:54 PM
Unknown Object (File)
Aug 21 2025, 8:15 PM
Subscribers

Details

Summary

Fix a mistake in the pcm_read_write test that would result in not
properly detecting 32bit calculation on 32bit architectures like i386.
As a consequence, the wrong values would be checked, thus failing the
test.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61911
Build 58795: arc lint + arc unit

Event Timeline

To the best of my knowledge, this should fix the test on i386. I haven't spotted any other test failures yet on CI, but that's not conclusive - some architectures seem to have build failures and won't run the tests.

LGTM. I just saw that https://ci.freebsd.org/job/FreeBSD-main-i386-test/lastUnstableBuild/testReport/junit/sys.sound/pcm_read_write/pcm_read/ reported this error, as a result of the 32 -> 24 bit conversion not happening.

EDIT: Seems like you linked to this as well yesterday. :-)

This revision is now accepted and ready to land.Jan 23 2025, 12:30 PM